[4.0] Fix Debug plugin to display query parameters#30717
[4.0] Fix Debug plugin to display query parameters#30717wilsonge merged 6 commits intojoomla:4.0-devfrom
Conversation
joomla-cms-bot
added
NPM Resource Changed
|
I have tested this item ✅ successfully on 9a522d0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717. |
|
@Fedik Maybe there is a small improvement possible? The call stack and the query plan have a bold heading, see green frame in the below screenshot. Would be nice to have something like that, e.g. "Query Parameters", for the parameters, too.
And there is a little inconsistency, the "Call Stack" heading is only capitalized, but the "QUERY PLAN" is completely uppercase. Maybe the "QUERY PLAN" can be changed to "Query Plan"? No need to do it with this PR here, future PR is also ok for me. |
"Explain table" rendered based on SQL response. And "Call Stack" is hard-coded in the debugbar. |
|
@Fedik And a heading for the parameters table, e.g. "Query Parameters", can that be added? |
|
Added, and update a styling a bit, to make it a little better readable |
|
I have tested this item ✅ successfully on 32565fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717. |
|
@alikon Please test this PR here ... am sure you will like it 😄 |
|
using the Prebuilt package i've got strange results i'll re-test later on a proper npm environment |
|
yea, that exact result with old JS |
|
I have tested this item ✅ successfully on 32565fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717. |
|
Thanks! |
* Joomla/4.0-dev: (844 commits) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) Removing card.scss overrides as we don't use those classes Use renderField() method to render fields (joomla#30738) [4.0] spelling (joomla#30742) [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581) [4.0] Fix saving images (joomla#30730) [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729) Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710) [4.0] Fix Debug plugin to display query parameters (joomla#30717) ...
6 participants
As additional to #30580
Summary of Changes
This fixing displaying of the SQL query parameters in debugBar.
Also optimised "Call Stack" rendering, that saves ~0.3s for rendering in my tests.
Testing Instructions
Apply path, run
npm installActual result BEFORE applying this Pull Request
Not possible to view the query parameters
Expected result AFTER applying this Pull Request
Click on "Params" icon to show the table with used query parameters
Documentation Changes Required
none