Skip to content

Fix tabs not wrapping and trigger horizontal scrolling#30675

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
Ruud68:configurationtabs
Sep 18, 2020
Merged

Fix tabs not wrapping and trigger horizontal scrolling#30675
wilsonge merged 1 commit intojoomla:4.0-devfrom
Ruud68:configurationtabs

Conversation

@Ruud68
Copy link
Contributor

@Ruud68 Ruud68 commented Sep 18, 2020

Pull Request for Issue #30667

Summary of Changes

Add flex wrap to enable wrap on tabs

Testing Instructions

  • apply pr,
  • npm run build:css

Actual result BEFORE applying this Pull Request

see issue #30667

Expected result AFTER applying this Pull Request

see issue #30667

Documentation Changes Required

nope

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 18, 2020
@sandewt
Copy link
Contributor

sandewt commented Sep 18, 2020

I have tested this item ✅ successfully on 7778840

Joomla! 4.0.0-beta5-dev Development [ Mañana ] 15-September-2020 19:15 GMT


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30675.

@Ruud68
Copy link
Contributor Author

Ruud68 commented Sep 18, 2020

Thanks @sandewt for testing!

@richard67
Copy link
Member

@chmst @wilsonge Could you test this PR with the laptops you have used for reproducing issue #28799 ? To me it seems other issues than the tabs, e.g. the width of the toolbar and header area either have been solved elsewhere meanwhile, or they are magically solved with this PR, too, or my 2 screens are not suitable to reproduce the other issues.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 7778840

Not sure if it is the best solution, but it is a solution which works, and for me it's ok.

Hoping for more opinions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30675.

@richard67 richard67 removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 18, 2020
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30675.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 18, 2020
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 18, 2020
@richard67
Copy link
Member

richard67 commented Sep 18, 2020

2 good tests, so RTC.

But I'd still like to know other opinions and if it has fixed issue #28799 completely or not.

@Ruud68
Copy link
Contributor Author

Ruud68 commented Sep 18, 2020

@richard67 thanks for testing and RTC :)

This is the default way bootstrap 4 implements tabs, see here: https://getbootstrap.com/docs/4.5/components/navs/#tabs

@chmst
Copy link
Contributor

chmst commented Sep 18, 2020

In any case it is better than before and resolves the issue with horizontal scrolling. So RTC is good for me.

@wilsonge
Copy link
Contributor

I mean it's ugly as hell but it wraps. Which is more than it does now

@wilsonge wilsonge merged commit 79d0f52 into joomla:4.0-dev Sep 18, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 18, 2020
@Quy Quy mentioned this pull request Sep 24, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants