[4.0] [Atum] Fix admin menu remaining hidden when enlarging screen width from small mobile to larger#30686
Merged
infograf768 merged 1 commit intojoomla:4.0-devfrom Sep 21, 2020
Conversation
Member
|
I have tested this item ✅ successfully on 44d1794 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 44d1794 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686. |
Member
|
Tks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30683 .
Summary of Changes
Add and remove CSS class "collapse" also for the sidebar wrapper when resizing the screen, in the same way as it is already done for the sidebar nav.
Testing Instructions
It needs current 4.0-dev for testing because last nightly build or Beta 4 don't include PR #30131 yet.
Result: The admin menu which is now at the bottom of the screen is expanded => ok.
Result: The admin menu at the bottom of the screen is collapsed => ok.
Result: See section "Actual result BEFORE applying this Pull Request" below.
npm run build:jsornpm ci.Result: See section "Expected result AFTER applying this Pull Request" below.
The issue happened to me also sometimes when skipping steps 2 and 3, but only when the particular page was shown for the very first time in that session, and even then not in all cases, so it was hard to reproduce. With steps 2 and 3 I could reproduce it reliably.
Actual result BEFORE applying this Pull Request
The admin menu remains invisible.
After a page reload the admin menu appears with collapsed status on the left hand side.
Expected result AFTER applying this Pull Request
The admin menu appears again at the left hand side.
Documentation Changes Required
None.
Additional information
I have no idea if this fix is the right fix. But it works. Hoping for feedback of experts.