Skip to content

[4.0] [Atum] Fix admin menu remaining hidden when enlarging screen width from small mobile to larger#30686

Merged
infograf768 merged 1 commit intojoomla:4.0-devfrom
richard67:4.0-dev-fix-atum-sidebar-wrapper-collapse
Sep 21, 2020
Merged

[4.0] [Atum] Fix admin menu remaining hidden when enlarging screen width from small mobile to larger#30686
infograf768 merged 1 commit intojoomla:4.0-devfrom
richard67:4.0-dev-fix-atum-sidebar-wrapper-collapse

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Sep 19, 2020

Pull Request for Issue #30683 .

Summary of Changes

Add and remove CSS class "collapse" also for the sidebar wrapper when resizing the screen, in the same way as it is already done for the sidebar nav.

Testing Instructions

It needs current 4.0-dev for testing because last nightly build or Beta 4 don't include PR #30131 yet.

  1. In backend on a desktop screen, reduce browser window width until the admin menu on the left hand side disappears and the burger button is shown at the bottom right corner.
  2. Click on the burger button.
    Result: The admin menu which is now at the bottom of the screen is expanded => ok.
  3. Click again on the burger button.
    Result: The admin menu at the bottom of the screen is collapsed => ok.
  4. Enlarge browser window width until the burger button disappears.
    Result: See section "Actual result BEFORE applying this Pull Request" below.
  5. Apply the patch of this PR.
  6. Run npm run build:js or npm ci.
  7. Clear browser cache or at least forced reload the backend page to get rid of cached old js.
  8. Reppeat steps 1 to 4.
    Result: See section "Expected result AFTER applying this Pull Request" below.

The issue happened to me also sometimes when skipping steps 2 and 3, but only when the particular page was shown for the very first time in that session, and even then not in all cases, so it was hard to reproduce. With steps 2 and 3 I could reproduce it reliably.

Actual result BEFORE applying this Pull Request

The admin menu remains invisible.

After a page reload the admin menu appears with collapsed status on the left hand side.

Expected result AFTER applying this Pull Request

The admin menu appears again at the left hand side.

Documentation Changes Required

None.

Additional information

I have no idea if this fix is the right fix. But it works. Hoping for feedback of experts.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 19, 2020
@richard67 richard67 changed the title [4.0] [Atum] Admin menu remaining hidden when enlarging screen width from small mobile to larger [4.0] [Atum] Fix admin menu remaining hidden when enlarging screen width from small mobile to larger Sep 19, 2020
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 44d1794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Sep 20, 2020

I have tested this item ✅ successfully on 44d1794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 20, 2020
@alikon
Copy link
Contributor

alikon commented Sep 20, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 20, 2020
@alikon alikon added NPM Resource Changed This Pull Request can't be tested by Patchtester J4 Issue PR-4.0-dev and removed J4 Issue labels Sep 20, 2020
@infograf768 infograf768 merged commit 528ae34 into joomla:4.0-dev Sep 21, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 21, 2020
@infograf768
Copy link
Member

Tks

@infograf768 infograf768 added this to the Joomla 4.0 milestone Sep 21, 2020
@richard67 richard67 deleted the 4.0-dev-fix-atum-sidebar-wrapper-collapse branch September 21, 2020 09:59
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments