Skip to content

[4.0] Cassiopea: fix category x layout#30710

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_cassiopea_cat_x_layout
Sep 21, 2020
Merged

[4.0] Cassiopea: fix category x layout#30710
wilsonge merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_cassiopea_cat_x_layout

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Sep 21, 2020

Pull Request for Issue #30703

Summary of Changes

As title says + also correcting rtl where the X was not displayed at all.

Testing Instructions

Edit an article in frontend in LTR and RTL

Patch needs npm.

Actual result BEFORE applying this Pull Request

Screenshot 2020-09-20 at 15 41 18

Expected result AFTER applying this Pull Request

Screen Shot 2020-09-21 at 09 33 28

Screen Shot 2020-09-21 at 09 27 56

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 21, 2020
@richard67
Copy link
Member

I have tested this item ✅ successfully on a0cee56


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30710.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Sep 21, 2020

I have tested this item ✅ successfully on a0cee56


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30710.

@Quy Quy removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 21, 2020
@Quy
Copy link
Contributor

Quy commented Sep 21, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30710.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 21, 2020
@Quy Quy added the PR-4.0-dev label Sep 21, 2020
@wilsonge wilsonge merged commit 02f230f into joomla:4.0-dev Sep 21, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Sep 21, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 21, 2020
@infograf768 infograf768 deleted the 4.0_cassiopea_cat_x_layout branch September 21, 2020 15:07
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants