[4.0] remove user from user group

[alikon]

Pull Request for Issue #30324.

Summary of Changes

all credits goes to @veperr

Testing Instructions

• create a group, get groupId
• create a user, get userId
• add user to group
• try to remove user from group using: UserHelper::removeUserFromGroup($userId, $groupId)

for the last point i've used the CLI command php cli/joomla.php user:removefromgroup

Actual result BEFORE applying this Pull Request

despite the successfull message from CLI command the user is not removed from that group ie it is not removed from the #__user_usergroup_map table

Expected result AFTER applying this Pull Request

the user is removed correctly from that table

[Fedik]

array_search() need to be checked for the result if ($serachResult !== false)
otherwise false will be cast to 0 that will remove wrong element

[SharkyKZ]

The whole change is not needed. Just need to run groups through array_values().

[alikon]

if you have a better solution i'm happy to close this one....

[ceford]

I have tested this item ✅ successfully on 127ef93

Works as described.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.}

[sandewt]

I have tested this item 🔴 unsuccessfully on 127ef93

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

See comment.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.}

[sandewt]

Result:

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.}

[veperr]

For clarification, the usage that failed for me (as reported in issue 30324) was calling UserHelper::removeUserFromGroup($userId, $groupId) from PHP code.
I did not try the CLI.

One the other hand I wrote a minimal custom function that did the job:
private function removeUserFromGroup($userId, $groupId){
$user = User::getInstance($userId);
// $user = new User($userId);
// $user->load($userId);
$userGrps = Access::getGroupsByUser($userId, false);

unset($userGrps[array_search($groupId, $userGrps)]);

$user->groups = $userGrps;
$user->save();

// Store the data.
if (!$user->save())
{
$this->setError($user->getError());

return false;

}
return $user->id;
}

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.}

[alikon]

please retest

[sandewt]

I have tested this item ✅ successfully on 1d44613

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.}

[Quy]

I have tested this item ✅ successfully on 1d44613

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30355.}

[wilsonge]

Thanks!