Skip to content

[4.0] Fixing com_media URLs for frontend#30617

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/fix/com-media-frontend
Sep 14, 2020
Merged

[4.0] Fixing com_media URLs for frontend#30617
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/fix/com-media-frontend

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Sep 11, 2020

Fixes #30005.

Summary of Changes

Currently media manager doesn't work in frontend if you're not logged in to backend because all URLs point to backend. This is an attempt to fix the issue.

Testing Instructions

node build.js --compile-js required.
Log out of backend.
Login to frontend.
Edit an article in frontend.
In editor click CMS Content -> Image to insert an image.

Actual result BEFORE applying this Pull Request

Doesn't work.

Expected result AFTER applying this Pull Request

Works.

Documentation Changes Required

No.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 11, 2020
@Quy
Copy link
Contributor

Quy commented Sep 12, 2020

It is working, however, the image will not insert into the article.

@SharkyKZ
Copy link
Contributor Author

I can't reproduce the issue. Are you getting any JS errors?

@Quy
Copy link
Contributor

Quy commented Sep 12, 2020

Sorry, never mind. I forgot to clear the browser's cache.

@Quy
Copy link
Contributor

Quy commented Sep 12, 2020

I have tested this item ✅ successfully on 2f83cd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30617.

1 similar comment
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 2f83cd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30617.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30617.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 13, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Sep 13, 2020
@wilsonge wilsonge merged commit fde13dc into joomla:4.0-dev Sep 14, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 14, 2020
@infograf768
Copy link
Member

Problem editing image, see #30664
@SharkyKZ

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments