convert icon-trash to fas fa-trash

[N6REJ]

Pull Request for Issue # .

Summary of Changes

changes the trash icon in actions dropdown to "fas fa-trash"

Testing Instructions

apply pr.
inspect action dropdown "trash" icon.
verify icon class is "fas fa-trash"

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

none

[N6REJ]

@sandewt

[toivo]

I have tested this item ✅ successfully on b2648c4

Tested successfully in Beta4-dev of 24 August.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[sandewt]

I have tested this item ✅ successfully on b2648c4

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

Tested links: see #30464
administrator/index.php?option=com_menus&view=items&menutype=0main-menu-blog
administrator/index.php?option=com_menus&view=items&menutype=mainmenu

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[hans2103]

I have tested this item ✅ successfully on 8028ea0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[hans2103]

@sandewt

[infograf768]

Restarted drone

[sandewt]

Sorry, but if we take a closer look, we show that not all spaces are placed correctly yet, for example:
I don't know if the intention is to change it now? Or in another PR?

• space is missing:
  

  joomla-cms/layouts/joomla/button/iconclass.php

  Line 15 in 8028ea0

  if(strpos($icon, 'fa-') !== false)

• two spaces:
  

  joomla-cms/layouts/joomla/toolbar/iconclass.php

  Line 23 in 8028ea0

  elseif ($icon === 'archive' || $icon === 'folder-close' || $icon === 'folder-folder-2' || $icon === 'folder-minus' || $icon === 'folder-plus-2' || $icon === 'folder-remove' || $icon === 'drawer-2')

And so on..

[EDIT]

[hans2103]

@sandewt this can be fixed in #30470 where I would like to merge two identical JLayout files into one.

[sandewt]

I have tested this item ✅ successfully on 8028ea0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[infograf768]

Restarted drone

[infograf768]

system-test-mysql still failing

 I trash article "Test Article"
   I am on page "/administrator/index.php?option=com_con..."
  [GET] http://localhost/test-install/administrator/index.php?option=com_content&view=articles
   I get config "timeout"
   I wait for element {"id":"filter_search"},90
   I get config "timeout"
   I wait for element {"id":"filter_search"},90
   I fill field {"id":"filter_search"},"Test Article"
   I click {"xpath":"//button[@aria-label='Search']"}
   I see "Test Article"
   I check all results 
  Selecting Checkall button
   I click toolbar button "Action"
   I wait 2
   I click toolbar button "trash"
  Screenshot and page source were saved into '/********/src/tests/Codeception/_output/' dir
 FAIL 

[N6REJ]

@richard67 @infograf768 drone passing now.

[infograf768]

Back to Pending. This PR has to be tested again.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[sandewt]

I have tested this item ✅ successfully on a2d4a66

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[ghost]

I have tested this item ✅ successfully on a2d4a66

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30468.}

[N6REJ]

closing since we've merged it #30470