Conversation
* Fix owntracks topic * Warn if per-topic secret and using HTTP
* 17track.net: Add package data attribute to summary sensors * Member comments
* bump aioasuswrt version * run gen_requirements
* Add websocket-based non-polling variant for songpal * linting fixes * changes based on Martin's feedback * Fix linting * add backoff timer for reconnects, fix variable naming (I thought that this wouldn't matter for internals..) * Remove poll configuration variable * bump the version just to be sure, the previous release lacked a version file (required for setup.py)
#19006) * Deprecate auto target all * Match on word 'all'
Re-use connection-pool of VOC
* Feature: support for the HK AVR * Remove testcode * Feature: support for the HK AVR * Remove testcode * Added checklist * Review fixes whitespaces * Lint fixes * Review fixes, add current source * Remove unused imports * Review fixes; State constants, dict[key] * More review fixes, Unknown state and Sources * Review fix; rename devices to entities
* Fix OwnTracks deadlocking * Fix deadlock
* Fail if new entity_id is in hass.states * Move check to websocket * Review comments
* Always add friendly name attribute * Only change device_info name
* Expose ZoneMinder availability to Home Assistant * Bump zm-py to 0.2.0 with the availability changes published
* Update synology_chat.py * Added verify_ssl option to notify.synology_chat Python requests will verify ssl by default, this configuration options allows the user to specify if they want to verify ssl or not. Non breaking change, default is True - do verify ssl.
* Add custom component to core * Add pyrail to reqs * Format & lint * Sort nmbs.py into place on coveragerc * Only set up station live if provided * Only set up sensor if config is provided * Fix line too long linting error * PR Remarks * Add docstrings * Fix hound line to long error * Fix quotes * Rebase coveragerc * PR Review * Init empty attrs * Dont include delay if there is none * PR review * Safer check * Rebase reqs * Generate req * Update homeassistant/components/sensor/nmbs.py Co-Authored-By: thibmaek <thibault.maekelbergh@iCloud.com> * PR remarks
* Check admin permission before able to manage config entries * Lint
* Rename is_owner decorator to is_admin * Update test_auth.py
* Add automation and script events to logbook filter events * Update logbook.py * Update logbook.py * Update logbook tests * Update test_logbook.py * Update test_logbook.py * Update test_logbook.py * Update test_logbook.py
* Bugfixes for connection issues
* Update ozw 0.1.2 * Update requirements_all.txt
balloob
requested review from
a team,
Danielhiversen,
Kane610,
bachya,
cdce8p,
dgomes,
fabaff,
kellerza,
ludeeus,
rytilahti,
scop and
syssi
as code owners
ghost
assigned
houndci-bot
reviewed
Jan 9, 2019
| entry: ConfigEntry) -> bool: | ||
| """Set up the esphome component.""" | ||
| # pylint: disable=redefined-outer-name | ||
| from aioesphomeapi import APIClient, APIConnectionError |
There was a problem hiding this comment.
redefinition of unused 'APIClient' from line 30
| async def async_load_from_store(self) -> List['EntityInfo']: | ||
| """Load the retained data from store and return de-serialized data.""" | ||
| # pylint: disable= redefined-outer-name | ||
| from aioesphomeapi import COMPONENT_TYPE_TO_INFO, DeviceInfo |
There was a problem hiding this comment.
redefinition of unused 'DeviceInfo' from line 30
| from .config_flow import EsphomeFlowHandler # noqa | ||
|
|
||
| if TYPE_CHECKING: | ||
| from aioesphomeapi import APIClient, EntityInfo, EntityState, DeviceInfo, \ |
There was a problem hiding this comment.
'aioesphomeapi.APIClient' imported but unused
'aioesphomeapi.DeviceInfo' imported but unused
'aioesphomeapi.EntityInfo' imported but unused
'aioesphomeapi.EntityState' imported but unused
'aioesphomeapi.ServiceCall' imported but unused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Platforms
Breaking Changes
Beta Fixes
All changes
entity_idavailable to value_template for MQTT binary sensor (@emontnemery - #19195) (binary_sensor.mqtt docs)