Skip to content

Rename is_owner decorator to is_admin#19266

Merged
balloob merged 2 commits intodevfrom
rename-is-owner-decorator
Dec 14, 2018
Merged

Rename is_owner decorator to is_admin#19266
balloob merged 2 commits intodevfrom
rename-is-owner-decorator

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Dec 13, 2018 •
edited
Loading

Description:

Rename require_owner decorator to require_admin and check for admin permissions instead of is_owner.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner December 13, 2018 16:26
@ghost ghost assigned balloob Dec 13, 2018
@ghost ghost added the in progress label Dec 13, 2018
@balloob balloob merged commit 4f98818 into dev Dec 14, 2018
@delete-merged-branch delete-merged-branch bot deleted the rename-is-owner-decorator branch December 14, 2018 09:19
@ghost ghost removed the in progress label Dec 14, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@balloob @dshokouhi
Rename is_owner decorator to is_admin (home-assistant#19266)
f7a6872 
* Rename is_owner decorator to is_admin

* Update test_auth.py
@balloob balloob mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@balloob balloob

Labels

cla-signed core integration: config integration: websocket_api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@balloob @homeassistant