Skip to content

Fix error when trying to log used UPnP device, if multiple found#19875

Merged
dgomes merged 1 commit intohome-assistant:devfrom
StevenLooman:igd_fixes
Jan 8, 2019
Merged

Fix error when trying to log used UPnP device, if multiple found#19875
dgomes merged 1 commit intohome-assistant:devfrom
StevenLooman:igd_fixes

Conversation

@StevenLooman
Copy link
Copy Markdown
Contributor

Description:

Fix an error when reporting which UPnP/IGD device is added, when multiple UPnP/IGD devices were found.

Related issue (if applicable): fixes #19862

Pull request in home-assistant.io with documentation (if applicable): -

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jan 8, 2019
@dgomes dgomes added this to the 0.85.0 milestone Jan 8, 2019
@dgomes dgomes merged commit cc6e70a into home-assistant:dev Jan 8, 2019
@ghost ghost removed the in progress label Jan 8, 2019
@DavidFW1960
Copy link
Copy Markdown

Ah thanks @StevenLooman I do have 2 routers (one of them is a Mesh Repeater, so a FB 7590 and a 7490)

@balloob balloob mentioned this pull request Jan 10, 2019
@StevenLooman StevenLooman deleted the igd_fixes branch January 27, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UPnp/IGD Integration not working

5 participants