Skip to content

Upgade colorlog to 4.0.2#19390

Merged
cgarwood merged 1 commit intodevfrom
upgrade-colorlog
Dec 17, 2018
Merged

Upgade colorlog to 4.0.2#19390
cgarwood merged 1 commit intodevfrom
upgrade-colorlog

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Dec 17, 2018

Description:

Changelog: https://github.com/borntyping/python-colorlog/commits/master

Example entry for configuration.yaml (if applicable):

$ hass --script check_config
INFO:homeassistant.util.package:Attempting install of colorlog==4.0.2
Testing configuration at /home/fab/.homeassistant
ERROR:homeassistant.util.yaml:mapping values are not allowed here
  in "/home/test/.homeassistant/configuration.yaml", line 117, column 13
Failed config
  General Errors: 
    - Error loading /home/test/.homeassistant/configuration.yaml: mapping values are not allowed here
  in "/home/test/.homeassistant/configuration.yaml", line 117, column 13

Successful config (partial)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@fabaff fabaff requested a review from kellerza as a code owner December 17, 2018 09:42
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Dec 17, 2018
@ghost ghost assigned fabaff Dec 17, 2018
@ghost ghost added the in progress label Dec 17, 2018
Copy link
Copy Markdown
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this version in esphomeyaml (with similar config checking code) successfully.

@cgarwood cgarwood merged commit 57ccd82 into dev Dec 17, 2018
@delete-merged-branch delete-merged-branch bot deleted the upgrade-colorlog branch December 17, 2018 22:54
@ghost ghost removed the in progress label Dec 17, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants