Add support for color_temp_command_template in MQTT light component#19675
Merged
emontnemery merged 3 commits intohome-assistant:devfrom Jan 1, 2019
dchesterton:dev
Merged
Add support for color_temp_command_template in MQTT light component#19675emontnemery merged 3 commits intohome-assistant:devfrom dchesterton:dev
emontnemery merged 3 commits intohome-assistant:devfrom
dchesterton:dev
Conversation
Contributor
|
Hi @dchesterton, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
houndci-bot
reviewed
Dec 31, 2018
| self._templates = { | ||
| CONF_BRIGHTNESS: config.get(CONF_BRIGHTNESS_VALUE_TEMPLATE), | ||
| CONF_COLOR_TEMP: config.get(CONF_COLOR_TEMP_VALUE_TEMPLATE), | ||
| CONF_COLOR_TEMP_COMMAND_TEMPLATE: config.get(CONF_COLOR_TEMP_COMMAND_TEMPLATE), |
There was a problem hiding this comment.
line too long (91 > 79 characters)
2 tasks
Contributor
|
Please add an abbreviation for the new configuration variable in mqtt/discovery.py |
Author
|
Thanks, I've added the abbreviation. |
Merged
kellerza
pushed a commit
to kellerza/ha-core
that referenced
this pull request
Jan 18, 2019
…ome-assistant#19675) * Add support for color_temp_command_template in MQTT light component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add support for changing the MQTT color_temp command with the
color_temp_command_templateconfig option, in the same way as the existingrgb_command_templateconfig option. This adds support for devices which expect the color_temp to be in Kelvin, such as SmartThings and Hubitat.Related issue (if applicable): fixes #19673 (among others)
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8000
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: