Skip to content

Fix a bug in Lutron RadioRA2 Scene support#19819

Merged
kellerza merged 1 commit intohome-assistant:devfrom
cdheiser:radiora2
Jan 6, 2019
Merged

Fix a bug in Lutron RadioRA2 Scene support#19819
kellerza merged 1 commit intohome-assistant:devfrom
cdheiser:radiora2

Conversation

@cdheiser
Copy link
Copy Markdown
Contributor

@cdheiser cdheiser commented Jan 6, 2019

Description:

The main lutron component was not properly passing the keypad name to the scene component, resulting in a stack trace like so:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/scene/lutron.py", line 22, in setup_platform
    (area_name, keypad_name, device, led) = scene_data
ValueError: not enough values to unpack (expected 4, got 3)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

The main lutron component was not properly passing the keypad name to the scene component, resulting in a stack trace like so:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/scene/lutron.py", line 22, in setup_platform
    (area_name, keypad_name, device, led) = scene_data
ValueError: not enough values to unpack (expected 4, got 3)
@ghost ghost added the in progress label Jan 6, 2019
@kellerza kellerza merged commit bf4830b into home-assistant:dev Jan 6, 2019
@ghost ghost removed the in progress label Jan 6, 2019
@kellerza kellerza added this to the 0.85.0 milestone Jan 6, 2019
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants