Skip to content

Expose ZoneMinder availability to Home Assistant#18946

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
rohankapoorcom:zoneminder-availability
Dec 14, 2018
Merged

Expose ZoneMinder availability to Home Assistant#18946
MartinHjelmare merged 2 commits intohome-assistant:devfrom
rohankapoorcom:zoneminder-availability

Conversation

@rohankapoorcom
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom commented Dec 3, 2018

Description:

Ties in the availability from ZoneMinder monitors to the camera and sensor entities created in Home Assistant.

Related issue (if applicable): fixes rohankapoorcom/zm-py#20
Depends on rohankapoorcom/zm-py#24

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ping me when it's out of WIP and I'll take a last look.

@rohankapoorcom rohankapoorcom changed the title WIP: Expose ZoneMinder availability to Home Assistant Expose ZoneMinder availability to Home Assistant Dec 9, 2018
@rohankapoorcom
Copy link
Copy Markdown
Member Author

@MartinHjelmare should be all set. I don't believe this needs a doc update.

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@rohankapoorcom
Copy link
Copy Markdown
Member Author

@MartinHjelmare Can I get a merge please?

@MartinHjelmare MartinHjelmare merged commit e8ec74b into home-assistant:dev Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
@rohankapoorcom rohankapoorcom deleted the zoneminder-availability branch December 14, 2018 07:19
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
* Expose ZoneMinder availability to Home Assistant

* Bump zm-py to 0.2.0 with the availability changes published
@balloob balloob mentioned this pull request Jan 10, 2019
@rohankapoorcom rohankapoorcom restored the zoneminder-availability branch January 17, 2019 06:58
@rohankapoorcom rohankapoorcom deleted the zoneminder-availability branch January 17, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report when a monitor is in an error state

3 participants