Skip to content

Add ZHA device handler library#19099

Merged
fabaff merged 10 commits intohome-assistant:devfrom
dmulcahey:dm/test-zha-event-foundation
Dec 12, 2018
Merged

Add ZHA device handler library#19099
fabaff merged 10 commits intohome-assistant:devfrom
dmulcahey:dm/test-zha-event-foundation

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented Dec 7, 2018

Description:

Adds support for additional devices and functionality by adding another library to ZHA. This library implements quirks functionality in Zigpy specifically for ZHA in HA. The library can be found here: https://pypi.org/project/zha-quirks/. This was implemented behind a toggle in HA and therefore can be turned on and off by changing a configuration option. No other input is needed from the user.

depends on functionality in #19095 and should not be merged until that is.

Docs PR: home-assistant/home-assistant.io#7808

@ghost ghost added the in progress label Dec 7, 2018
@dmulcahey dmulcahey closed this Dec 7, 2018
@dmulcahey dmulcahey reopened this Dec 7, 2018
@ghost ghost added in progress and removed in progress labels Dec 7, 2018
@dmulcahey dmulcahey closed this Dec 9, 2018
@ghost ghost removed the in progress label Dec 9, 2018
@dmulcahey dmulcahey changed the title ZHA - Add device handler library WIP - ZHA - Add device handler library Dec 10, 2018
@dmulcahey dmulcahey reopened this Dec 10, 2018
@ghost ghost added the in progress label Dec 10, 2018
dmulcahey and others added 2 commits December 10, 2018 11:05
home-assistant#19141 should be what ultimately corrects this issue.
@dmulcahey dmulcahey changed the title WIP - ZHA - Add device handler library ZHA - Add device handler library Dec 10, 2018
@fabaff fabaff changed the title ZHA - Add device handler library Add ZHA device handler library Dec 12, 2018
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Dec 12, 2018

This PR requires a documentation update as there is a new option.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that we missed to exclude a zha package module from coverage calculation in one of the later PRs. Please add the event module to .coveragerc.

@dmulcahey
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare .coveragerc updated

@dmulcahey
Copy link
Copy Markdown
Contributor Author

@fabaff all set.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 031ee71 into home-assistant:dev Dec 12, 2018
@ghost ghost removed the in progress label Dec 12, 2018
@dmulcahey dmulcahey deleted the dm/test-zha-event-foundation branch December 26, 2018 12:10
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants