Resolves #17196, Resolves #18739 - Hue Beyond light fixture errors#19874
Merged
balloob merged 3 commits intohome-assistant:devfrom Jan 9, 2019
alistairg:hue
Merged
Resolves #17196, Resolves #18739 - Hue Beyond light fixture errors#19874balloob merged 3 commits intohome-assistant:devfrom alistairg:hue
balloob merged 3 commits intohome-assistant:devfrom
alistairg:hue
Conversation
homeassistant
added
cla-signed
platform: light.hue
small-pr
ghost
added
the
houndci-bot
reviewed
Jan 8, 2019
| def device_info(self): | ||
| """Return the device info.""" | ||
| if self.light.type in ('LightGroup', 'Room'): | ||
| if self.light.type in ('LightGroup', 'Room', 'Luminaire', 'LightSource'): |
| elif item_id not in progress_waiting: | ||
| current[item_id].async_schedule_update_ha_state() | ||
| if current[item_id].entity_id is None: | ||
| _LOGGER.error("ERROR: Current Item %s has no entity ID in API type '%s'. Skipping update.", current[item_id].name, api_type) |
There was a problem hiding this comment.
line too long (140 > 79 characters)
| if light_id not in progress_waiting: | ||
| light.async_schedule_update_ha_state() | ||
| if light.entity_id is None: | ||
| _LOGGER.error("ERROR: Light %s has no entity ID. Skipping update.", light.name) |
houndci-bot
reviewed
Jan 8, 2019
| def device_info(self): | ||
| """Return the device info.""" | ||
| if self.light.type in ('LightGroup', 'Room'): | ||
| if self.light.type in ('LightGroup', 'Room', |
| for light_id, light in current.items(): | ||
| if light_id not in progress_waiting: | ||
| light.async_schedule_update_ha_state() | ||
| light.async_schedule_update_ha_state() |
Member
|
Nice catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Hue Beyond light fixtures report themselves as special groups, that were not correctly recognized by the platform. This lead to various "no entity id" errors amongst others.
This pull adds recognition for the "Luminaire" and "LightGroup" group types, which resolves this error.
**Related issue (if applicable): Fixes #17196, Fixes #18739
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: