Skip to content

Fix list (fixes #19235)#19258

Merged
balloob merged 1 commit intodevfrom
polly-voices
Dec 13, 2018
Merged

Fix list (fixes #19235)#19258
balloob merged 1 commit intodevfrom
polly-voices

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Dec 13, 2018

Description:

Fix list

Related issue (if applicable): fixes #19235

Example entry for configuration.yaml (if applicable):

tts:
  - platform: amazon_polly
    aws_access_key_id: AWS_ACCESS_KEY_ID
    aws_secret_access_key: AWS_SECRET_ACCESS_KEY
    voice: Mia

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned fabaff Dec 13, 2018
@ghost ghost added the in progress label Dec 13, 2018
@fabaff fabaff added this to the 0.84.2 milestone Dec 13, 2018
OttoWinter
OttoWinter approved these changes Dec 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bug 😄

@balloob balloob merged commit 66aa7d0 into dev Dec 13, 2018
@delete-merged-branch delete-merged-branch bot deleted the polly-voices branch December 13, 2018 15:44
@ghost ghost removed the in progress label Dec 13, 2018
balloob pushed a commit that referenced this pull request Dec 14, 2018
@fabaff @balloob
Fix list (fixes #19235) (#19258)
965e47e
@balloob balloob mentioned this pull request Dec 14, 2018
Merged
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@fabaff @dshokouhi
Fix list (fixes home-assistant#19235) (home-assistant#19258)
82b2d5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OttoWinter OttoWinter OttoWinter approved these changes

Assignees

@fabaff fabaff

Labels

cherry-picked cla-signed integration: tts small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.84.2

Development

Successfully merging this pull request may close these issues.

Some Amazon Polly Voices are not working

4 participants

@fabaff @OttoWinter @balloob @homeassistant