Fix Insteon open/closed sensors#19050
Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom Dec 13, 2018
teharris1:iolinc
Merged
Fix Insteon open/closed sensors#19050MartinHjelmare merged 2 commits intohome-assistant:devfrom teharris1:iolinc
MartinHjelmare merged 2 commits intohome-assistant:devfrom
teharris1:iolinc
Conversation
homeassistant
added
integration: insteon
platform: binary_sensor.insteon
small-pr
ghost
added
the
balloob
reviewed
Dec 6, 2018
Contributor
Author
|
@balloob are there any other questions about this PR? |
MartinHjelmare
approved these changes
Dec 13, 2018
|
This issue is still in 0.84. Should I re-open a new issue? |
Member
|
The fix is not released yet. |
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A change made in 0.83.0 created a bug with Insteon Open/closed Binary Sensors. This change fixes that bug.
Related issue (if applicable): fixes #18939
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: