Skip to content

Synology chat add verify ssl#19276

Merged
fabaff merged 2 commits intohome-assistant:devfrom
bremor:synology-chat-add-verify-ssl
Dec 14, 2018
Merged

Synology chat add verify ssl#19276
fabaff merged 2 commits intohome-assistant:devfrom
bremor:synology-chat-add-verify-ssl

Conversation

@bremor
Copy link
Copy Markdown
Contributor

@bremor bremor commented Dec 13, 2018

Description:

Added verify_ssl option into synology_chat to allow users to disable ssl verification for self signed certs or direct IP address in the url.

Related issue (if applicable): fixes # Not applicable

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7833

Example entry for configuration.yaml (if applicable):

notify:
  - platform: synology_chat
    name: hass_synchat
    verify_ssl: True
    resource: https://example.your.synology.com/webapi/entry.cgi?api=SYNO.Chat.External&method=incoming&version=1&token=ABCDEFG

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Python requests will verify ssl by default, this configuration options allows the user to specify if they want to verify ssl or not. Non breaking change, default is True - do verify ssl.
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 74a93fe into home-assistant:dev Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
* Update synology_chat.py

* Added verify_ssl option to notify.synology_chat

Python requests will verify ssl by default, this configuration options allows the user to specify if they want to verify ssl or not. Non breaking change, default is True - do verify ssl.
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants