Synology chat add verify ssl#19276
Merged
fabaff merged 2 commits intohome-assistant:devfrom Dec 14, 2018
bremor:synology-chat-add-verify-ssl
Merged
Synology chat add verify ssl#19276fabaff merged 2 commits intohome-assistant:devfrom bremor:synology-chat-add-verify-ssl
fabaff merged 2 commits intohome-assistant:devfrom
bremor:synology-chat-add-verify-ssl
Conversation
Python requests will verify ssl by default, this configuration options allows the user to specify if they want to verify ssl or not. Non breaking change, default is True - do verify ssl.
2 tasks
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
* Update synology_chat.py * Added verify_ssl option to notify.synology_chat Python requests will verify ssl by default, this configuration options allows the user to specify if they want to verify ssl or not. Non breaking change, default is True - do verify ssl.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added verify_ssl option into synology_chat to allow users to disable ssl verification for self signed certs or direct IP address in the url.
Related issue (if applicable): fixes # Not applicable
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7833
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: