Skip to content

Check admin permission before able to manage config entries#19265

Merged
balloob merged 2 commits intodevfrom
admin-perm-config-entries
Dec 14, 2018
Merged

Check admin permission before able to manage config entries#19265
balloob merged 2 commits intodevfrom
admin-perm-config-entries

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Dec 13, 2018

Description:

Check that a user is part of the admin group before allowing changes to config entries.

We'll need to add such checks to all config APIs.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob merged commit a5a896b into dev Dec 14, 2018
@delete-merged-branch delete-merged-branch bot deleted the admin-perm-config-entries branch December 14, 2018 09:19
@ghost ghost removed the in progress label Dec 14, 2018
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants