Skip to content

Fix OwnTracks deadlocking#19260

Merged
balloob merged 2 commits intodevfrom
fix-owntracks-deadlock
Dec 13, 2018
Merged

Fix OwnTracks deadlocking#19260
balloob merged 2 commits intodevfrom
fix-owntracks-deadlock

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Dec 13, 2018

Description:

When people had manually configured the owntracks platform, we got a circular dependency and deadlock.

Example entry for configuration.yaml (if applicable):

device_tracker:
  platform: owntracks

# owntracks config entry.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Dec 13, 2018
@ghost ghost added the in progress label Dec 13, 2018
@balloob balloob added this to the 0.84.2 milestone Dec 13, 2018
@balloob balloob merged commit 34cfdb4 into dev Dec 13, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-owntracks-deadlock branch December 13, 2018 19:56
@ghost ghost removed the in progress label Dec 13, 2018
balloob added a commit that referenced this pull request Dec 14, 2018
* Fix OwnTracks deadlocking

* Fix deadlock
@balloob balloob mentioned this pull request Dec 14, 2018
@raccettura
Copy link
Copy Markdown
Contributor

Tried this but there might still be a problem. I've now got owntracks working with the http webhook. If I remove my device from known_devices.yml it will re-add itself.

I then tried adding the following to my config:

owntracks:
  max_gps_accuracy: 150
  waypoints: true
  events_only: true
  waypoint_whitelist:
    - raccettura
  region_mapping:
    home: home
    work: work

Then restarted and made owntracks update my location. No device was added to known_devices.yml. Accuracy was +/- 65m... which is well under 150 I'm specifying. I even upped it to 200.

Remove the config and once again I get a device added to known_devices.yml.

dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
* Fix OwnTracks deadlocking

* Fix deadlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants