Support for the Harman Kardon AVR#18471
Merged
MartinHjelmare merged 15 commits intohome-assistant:devfrom Dec 13, 2018
Merged
Conversation
Contributor
ghost
added
the
houndci-bot
reviewed
Nov 14, 2018
Devqon
force-pushed
the
mediaplayer_hk-avr
branch
from
94c8815 to
58ba32b
Compare
Devqon
changed the title
2 tasks
Devqon
changed the title
fabaff
changed the title
fabaff
reviewed
Nov 25, 2018
…ssistant into mediaplayer_hk-avr # Conflicts: # homeassistant/components/media_player/harman_kardon_avr.py
houndci-bot
reviewed
Nov 26, 2018
MartinHjelmare
requested changes
Nov 29, 2018
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Two small changes left, otherwise looks good! @fabaff?
…into mediaplayer_hk-avr # Conflicts: # requirements_all.txt
Contributor
Author
|
@MartinHjelmare how can I make sure that this platform is merged as soon as possible? Is there something else I need to do? Or is it just waiting untill someone with authorization merges the pull request? |
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
* Feature: support for the HK AVR * Remove testcode * Feature: support for the HK AVR * Remove testcode * Added checklist * Review fixes whitespaces * Lint fixes * Review fixes, add current source * Remove unused imports * Review fixes; State constants, dict[key] * More review fixes, Unknown state and Sources * Review fix; rename devices to entities
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Support the Harman Kardon AVR as media players
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
See #7581
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: