Fix call to super()#19279
Merged
fabaff merged 3 commits intohome-assistant:devfrom Dec 14, 2018
marchingphoenix:lutron-fix-super-call
Merged
Fix call to super()#19279fabaff merged 3 commits intohome-assistant:devfrom marchingphoenix:lutron-fix-super-call
fabaff merged 3 commits intohome-assistant:devfrom
marchingphoenix:lutron-fix-super-call
Conversation
homeassistant
added
platform: light.lutron
small-pr
ghost
assigned
Contributor
Author
|
Entire platform currently has no test coverage. That's how this problem wasn't caught in the first place. |
MartinHjelmare
requested changes
Dec 14, 2018
houndci-bot
reviewed
Dec 14, 2018
MartinHjelmare
approved these changes
Dec 14, 2018
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Thanks! Can be merged when build passes.
balloob
pushed a commit
that referenced
this pull request
Dec 14, 2018
Merged
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
* home-assistant#19273: fix call to super() * home-assistant#19273: adjust to python3 standards. * home-assistant#19273: remove bad test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix call to super() change made in #18650
Related issue (if applicable): fixes #19273
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/A
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.N/A
If the code does not interact with devices:
Entire platform currently has no tests.