Merged
Conversation
homeassistant
added
integration: weather
core
small-pr
ghost
assigned
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Do we need to mark this breaking change, since the default scan interval will change?
Member
Author
|
Doesn't harm to add it to the release notes. I doubt that people will see an impact but better be safe than sorry. Breaking change: |
MartinHjelmare
approved these changes
Dec 11, 2018
balloob
reviewed
Jan 10, 2019
|
|
||
| ENTITY_ID_FORMAT = DOMAIN + '.{}' | ||
|
|
||
| SCAN_INTERVAL = timedelta(seconds=30) |
Member
There was a problem hiding this comment.
This seems overaggressive for a weather API.
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Use the same interval as for the sensor. It's a sensor platform and should also behave as one.
Was spotted during the review of the
air_pollutantscomponent by @MartinHjelmare.Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass