Fetch only required data from Huawei LTE#17618
Merged
balloob merged 1 commit intohome-assistant:devfrom Dec 14, 2018
scop:huawei-lte-required-data
Merged
Fetch only required data from Huawei LTE#17618balloob merged 1 commit intohome-assistant:devfrom scop:huawei-lte-required-data
balloob merged 1 commit intohome-assistant:devfrom
scop:huawei-lte-required-data
Conversation
When debug logging is enabled, still fetch everything in order to provide indication of available/supported data to users, as instructed in docs.
Member
|
I'm not sure what will be in the right direction. That is more a general question and maybe we should write an architecture about this. General, I would love to remove the |
Member
Author
|
A problem is that it might not be possible to enumerate what "all available data" is, and offering only a subset would not be sustainably maintainable (or would be overly restrictive). |
balloob
approved these changes
Dec 14, 2018
Member
|
Pascal, I think that the current PR is not related to a discussion about monitored conditions. I would see this as an optimization. |
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
When debug logging is enabled, still fetch everything in order to provide indication of available/supported data to users, as instructed in docs.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Don't fetch data that is not going to be used. When debug logging is enabled, still fetch everything in order to provide indication of available/supported data to users, as instructed in docs.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: