Skip to content

Fetch only required data from Huawei LTE#17618

Merged
balloob merged 1 commit intohome-assistant:devfrom
scop:huawei-lte-required-data
Dec 14, 2018
Merged

Fetch only required data from Huawei LTE#17618
balloob merged 1 commit intohome-assistant:devfrom
scop:huawei-lte-required-data

Conversation

@scop
Copy link
Copy Markdown
Member

@scop scop commented Oct 19, 2018

Description:

Don't fetch data that is not going to be used. When debug logging is enabled, still fetch everything in order to provide indication of available/supported data to users, as instructed in docs.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

When debug logging is enabled, still fetch everything in order to
provide indication of available/supported data to users, as instructed
in docs.
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Nov 3, 2018

I'm not sure what will be in the right direction. That is more a general question and maybe we should write an architecture about this.

General, I would love to remove the CONF_MONITORED_CONDITIONS. Home Assistant should grab all available data and the user decide on UI what he want to see and in which way.

@scop
Copy link
Copy Markdown
Member Author

scop commented Nov 4, 2018

A problem is that it might not be possible to enumerate what "all available data" is, and offering only a subset would not be sustainably maintainable (or would be overly restrictive).

@fabaff fabaff changed the title huawei_lte: Fetch only required data Fetch only required data from Huawei LTE Dec 12, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Dec 14, 2018

Pascal, I think that the current PR is not related to a discussion about monitored conditions. I would see this as an optimization.

@balloob balloob merged commit 1c147b5 into home-assistant:dev Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
@scop scop deleted the huawei-lte-required-data branch December 14, 2018 16:39
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
When debug logging is enabled, still fetch everything in order to
provide indication of available/supported data to users, as instructed
in docs.
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants