Add package data attribute to 17track.net summary sensors#19213
Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom Dec 12, 2018
Merged
Add package data attribute to 17track.net summary sensors#19213MartinHjelmare merged 2 commits intohome-assistant:devfrom
MartinHjelmare merged 2 commits intohome-assistant:devfrom
Conversation
homeassistant
added
platform: sensor.seventeentrack
small-pr
fabaff
changed the title
MartinHjelmare
approved these changes
Dec 12, 2018
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
…tant#19213) * 17track.net: Add package data attribute to summary sensors * Member comments
Merged
ghost
added
integration: seventeentrack
and removed
platform: sensor.seventeentrack
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
From a forum request: users want 17track.net summary sensors to include a JSON attribute containing the packages applicable to that status (for easier display via a table card in Lovelace). This PR takes care of that.
The PR also fixes an issue wherein 17track.net sensors couldn't be used in Jinja templates because of their entity ID.
BREAKING CHANGE: In order to fix the below bug, default entity_ids will change (for example,
sensor.17track_packages_deliveredwill change tosensor.seventeentrack_packages_delivered).Related issue (if applicable): fixes #19212
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass