Skip to content

Add permission check to light service#19259

Merged
balloob merged 1 commit intodevfrom
light-permission
Dec 14, 2018
Merged

Add permission check to light service#19259
balloob merged 1 commit intodevfrom
light-permission

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Dec 13, 2018

Description:

The light turn on service doesn't use the entity service helper, so needs to manually check for permissions.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Dec 13, 2018
@ghost ghost added the in progress label Dec 13, 2018
@balloob balloob merged commit 0eb0faf into dev Dec 14, 2018
@delete-merged-branch delete-merged-branch bot deleted the light-permission branch December 14, 2018 09:18
@ghost ghost removed the in progress label Dec 14, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants