Skip to content

feat(web): add support for LVM #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joseivanlopez merged 118 commits into from
Mar 27, 2025
Merged

feat(web): add support for LVM #2216

joseivanlopez merged 118 commits into from
Mar 27, 2025

Conversation

@joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Mar 27, 2025 •
edited
Loading

Add basic support for LVM in the web UI:

  • Add, edit and delete new volume groups.
  • Add, edit and delete new logical volumes.

Out of scope:

  • Reuse existings volume groups.
  • Thin pools and thin volumes.
  • Create physical volumes manually.

joseivanlopez and others added 30 commits March 7, 2025 15:00
@joseivanlopez
storage: add vgs and lvs to model schema
ccdd718
@joseivanlopez
storage: add conversion to model for LVM
8b545a1
@joseivanlopez
feat(storage): make vg name mandatory
851d33d
@joseivanlopez
fix(storage): drive model includes the searching name
f2bdb8c 
- Includes the name used for searching the device when the device
  is not found.
@joseivanlopez
fix(storage): only exclude skipped devices from model
e99fb73 
- The model includes all the devices, including devices with errors.
@joseivanlopez
fix(storage): model always generates a min size
6970c14 
- Min size is even generated when a device is not found.
@joseivanlopez
storage: add checker for model support
4be9c6a
@joseivanlopez
storage: use model support checker
e70204a
@ancorgs @joseivanlopez
web: Extract repeated code to a new DeviceMenu component
5983925
@ancorgs @joseivanlopez
web: First real implementation of hasPV
4016485
@ancorgs @joseivanlopez
web: Refresh types/config-model.ts
451637c
@ancorgs @joseivanlopez
web: First version of VolumeGroupEditor
eb08eb0
@ancorgs @joseivanlopez
web: Add list of logical volumes
c0764ff
@joseivanlopez
web: add initial storage model hook
552352d
@joseivanlopez
web: use model hook
8555ca7
@joseivanlopez
web: add basic test for config editor
4c46f93
@joseivanlopez
storage: make global encryption to work with LVM
e6cf582
@joseivanlopez
service: changelog
8668a57
@joseivanlopez
rust: changelog
0dd659f
@joseivanlopez
web: changelog
7d64c00
@joseivanlopez
web: rename utils file
2dfb8d2
@joseivanlopez
web: extract components
44a7bb6
@joseivanlopez
feat(ui): show volume groups (#2089)
8fefec1 
Show the volume groups used for the installation and their logical
volumes.

Note: The volume groups and logical volumes cannot be edited yet. 

![Screenshot From 2025-03-07
11-35-51](https://github.com/user-attachments/assets/a0ebfef4-326d-4701-af62-8192fe22d166)

![Screenshot From 2025-03-06
16-05-56](https://github.com/user-attachments/assets/cd76a837-d024-491d-916e-daba5c33dd0e)
@joseivanlopez
Merge branch 'after-release-beta2' into sync-branch
09da914
@joseivanlopez
Sync storage-lvm branch (#2136)
404a07d 
Merge after-release-beta2 into storage-lvm.
@dgdavid
fix(web): enable auto-width for popups without a variant
e98047d 
Popups now automatically adjust their width when no variant is provided,
preventing them from being unnecessarily wide with short content.

It also removes deprecated size properties.
@dgdavid
fix(web): improve login page layout
34b3f69 
Adjusted the layout of the form to improve its visual "flow and rhythm".
@dgdavid
fix(web): accept a ReactNode as Page/Section#title
4149d43 
The title can now be any valid ReactNode, not just a string.
@dgdavid
fix(web): layout improvements (#2137)
e2d44c6 
## Problem

Commit a1a016b introduced some
side-effects here and there that are easy to fix by adjusting affected
layouts.

## Solution

Allow popups to use an auto width when no variant is given plus
reworking the login form.
@dgdavid @joseivanlopez
fix(web): prevent PF/FormGroup from filling full width
ad1bc9e 
Override PatternFly styles to ensure that a FormGroup aligns to the
start of its flex container instead of stretching to fill all available
space by default.

https://developer.mozilla.org/en-US/docs/Web/CSS/justify-content#normal
joseivanlopez and others added 14 commits March 26, 2025 15:31
@joseivanlopez
web: add logical volume management
619651a 
- Add, edit and delete logical volumes.
@joseivanlopez
web: use AutoSizeText in PartitionPage
8b26586
@dgdavid
refactor(web): change the alerts look and feel
6473471 
Refactor the alert design to stop rendering them as "boxes", which were
cluttering the interface. Instead, they now use a left border and a
gradient background to maintain visual hints about the scope of their
content without the boxy appearance.
@joseivanlopez
web: add lv name when creating from partition
8616c05
@joseivanlopez
web: preselect disks for system volume group
4b6b623
@joseivanlopez
web: fix test
beef8b3
@ancorgs
web: Align grids of multi-line checkboxes
f145f01
@ancorgs
web: Handle more recoverable errors
53e05e8
@ancorgs
web: Reword some ConfigEditor buttons
8688842
@ancorgs
web: Clarify wording about boot partitions
7cc76e2
@imobachgs
refactor(web): change the alerts look and feel (#2212)
88c40d5 
Refactor the alert design to stop rendering them as "boxes", which were
cluttering the interface. Instead, they now use a left border and a
gradient background to maintain visual hints about the scope of their
content without the boxy appearance.

| Before | After  |
|-|-|
| ![localhost_8080_
(29)](https://github.com/user-attachments/assets/d9e717ae-ac7d-4e3a-b02d-89a82173d253)
| ![localhost_8080_
(28)](https://github.com/user-attachments/assets/c52a50ba-dc47-47db-b573-7263eb2aca5c)
|
@joseivanlopez
Merge pull request #7 from ancorgs/manage-lvs-fixes
53a79c6 
Changes on top of latest LVM features
@joseivanlopez
feat(web): manage logical volumes (#2200)
0be7cd3 
Allow managing LVM logical volumes (add, edit and delete).

Notes: 

* *LogicalVolumePage* and *PartitionPage* components must be refactored.
* The validation in both pages should be adaped in order to follow the
same approach as the rest of the UI (i.e., validating on accept).

Disclaimer: 

The code in this PR was done in a hurry for including LVM managent in
SLE16 Beta3. It does not satisfy our expected quality thresholds and
will be refactored as soon as possible.
@joseivanlopez
Merge branch 'master' into storage-lvm
90bac81
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 27, 2025
View reviewed changes
@joseivanlopez joseivanlopez marked this pull request as ready for review March 27, 2025 11:51
imobachgs
imobachgs approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, I am not going through 7k lines of code :-) However, all that code have been reviewed in several PRs, the changes files look good and the CI problems are not related to it.

ancorgs
ancorgs approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not gone through all the code either. But I have tested the result, including the redefined regexp and it looks good to me.

@joseivanlopez joseivanlopez merged commit 26bedf0 into master Mar 27, 2025
9 of 11 checks passed
@joseivanlopez joseivanlopez deleted the storage-lvm branch March 27, 2025 12:33
@imobachgs imobachgs mentioned this pull request Mar 27, 2025
Merged
imobachgs added a commit that referenced this pull request Mar 27, 2025
@imobachgs
Update to release 13 (#2217)
e176c9d 
Prepare for releasing Agama 13:

- #2041
- #2074
- #2088
- #2089
- #2094
- #2097
- #2098
- #2100
- #2101
- #2104
- #2106
- #2107
- #2108
- #2113
- #2115
- #2116
- #2117
- #2118
- #2120
- #2121
- #2122
- #2123
- #2124
- #2125
- #2126
- #2128
- #2132
- #2135
- #2136
- #2137
- #2139
- #2142
- #2145
- #2146
- #2147
- #2148
- #2151
- #2153
- #2155
- #2156
- #2157
- #2158
- #2159
- #2160
- #2161
- #2163
- #2165
- #2172
- #2174
- #2177
- #2179
- #2180
- #2181
- #2182
- #2183
- #2184
- #2186
- #2187
- #2188
- #2191
- #2192
- #2193
- #2195
- #2197
- #2198
- #2199
- #2200
- #2201
- #2203
- #2204
- #2205
- #2206
- #2207
- #2209
- #2212
- #2213
- #2214
- #2215
- #2216
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 27, 2025
@bmwiedemann
Update agama-web-ui to version 0 / rev 14 via SR 1256469
ab62382 
https://build.opensuse.org/request/show/1256469
by user IGonzalezSosa + anag+factory
- Version 13

- Add basic support for creating LVM volume groups and logical
  volumes (gh#agama-project/agama#2216).

- Change switches by checkboxes (gh#agama-project/agama#2168).
- Restructure the encryption form (gh#agama-project/agama#2168).

- Properly handle empty lists of unsupported AutoYaST elements
  (gh#agama-project/agama#2196).

- Stop parsing errors from SCC at frontend side and simply render
  them as returned by the backend (gh#agama-project/agama#2193).

- Stop displaying the hostname alert once the system is registered
  (gh#agama-project/agama#2183).

- Allow temporary removal of the root file system
 (gh#agama-project/agama#2160).
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 27, 2025
@bmwiedemann
Update rubygem-agama-yast to version 13.devel1 / rev 17 via SR 1256470
fc41e8f 
https://build.opensuse.org/request/show/1256470
by user IGonzalezSosa + anag+factory
- Version 13

- Extend storage model for basic LVM support
  (gh#agama-project/agama#2216).

- Install registred addon product (its *-release package)
  (related to jsc#AGM-100)

- Support for autoyast manual files deployment with exception
  of deploying directories and files_script
  (gh#agama-project/agama#2121)

- Add extensions from the registration server (automatic
  installation only) (jsc#AGM-100)

- Symlink the /mnt/etc/resolv.conf to the NetworkManager running
  one in order to have DNS resolution in the chroot post scripts
  (bsc#1235617, gh#agama-project/agama#2179).

  (gh#agama-project/agama#2140).
  will be proposed by storage. Currently works only for BLS.
@imobachgs imobachgs mentioned this pull request Apr 22, 2025
Merged
imobachgs added a commit that referenced this pull request Apr 22, 2025
@imobachgs
Update to release 14 (#2282)
99c759c 
Prepare to release Agama 14:

* #1994
* #2041
* #2103
* #2178
* #2189
* #2200
* #2205
* #2209
* #2212
* #2213
* #2214
* #2215
* #2216
* #2217
* #2219
* #2220
* #2224
* #2225
* #2226
* #2227
* #2228
* #2230
* #2231
* #2232
* #2233
* #2235
* #2237
* #2239
* #2241
* #2242
* #2244
* #2245
* #2246
* #2247
* #2248
* #2249
* #2250
* #2251
* #2252
* #2253
* #2254
* #2255
* #2256
* #2257
* #2259
* #2260
* #2262
* #2265
* #2266
* #2268
* #2269
* #2271
* #2272
* #2273
* #2275
* #2276
* #2278
* #2281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imobachgs imobachgs imobachgs approved these changes

@ancorgs ancorgs ancorgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joseivanlopez @imobachgs @ancorgs @dgdavid