feat(ruby): collect the logs at the end of the installation#2148
Merged
imobachgs merged 4 commits intoafter-release-beta2from Mar 12, 2025
Merged
feat(ruby): collect the logs at the end of the installation#2148imobachgs merged 4 commits intoafter-release-beta2from
imobachgs merged 4 commits intoafter-release-beta2from
Conversation
dgdavid
reviewed
Mar 12, 2025
Contributor
dgdavid
left a comment
There was a problem hiding this comment.
There is an orphan test failing at manager now.
agama/service/test/agama/manager_test.rb
Lines 237 to 240 in 5b8933e
Pull Request Test Coverage Report for Build 13810391035Details
💛 - Coveralls |
dgdavid
approved these changes
Mar 12, 2025
* Save the logs into the installed system. * Set the proper permissions (700) to the /var/log/agama-installation folder.
dgdavid
approved these changes
Mar 12, 2025
Contributor
dgdavid
left a comment
There was a problem hiding this comment.
Thanks for catching the wrong target branch. Not it looks better :)
Merged
imobachgs
added a commit
that referenced
this pull request
Mar 27, 2025
Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agama does not copy the logs to the installed system, so they are lost. Additionally, the /var/log/agama-installation permissions are way too open.
Solution
Testing