Skip to content

feat(ruby): collect the logs at the end of the installation#2148

Merged
imobachgs merged 4 commits intoafter-release-beta2from
collect-logs
Mar 12, 2025
Merged

feat(ruby): collect the logs at the end of the installation#2148
imobachgs merged 4 commits intoafter-release-beta2from
collect-logs

Conversation

@imobachgs
Copy link
Contributor

Problem

Agama does not copy the logs to the installed system, so they are lost. Additionally, the /var/log/agama-installation permissions are way too open.

Solution

Testing

  • Added a new unit test
  • Tested manually

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an orphan test failing at manager now.

it "collects the logs" do
expect(subject).to receive(:collect_logs)
subject.finish_installation(method)
end

@coveralls
Copy link

coveralls commented Mar 12, 2025

Pull Request Test Coverage Report for Build 13810391035

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 72.674%

Files with Coverage Reduction New Missed Lines %
service/service/lib/agama/storage/finisher.rb 2 98.65%
service/service/lib/agama/manager.rb 8 85.92%
Totals Coverage Status
Change from base Build 13746429284: 0.004%
Covered Lines: 19906
Relevant Lines: 27391

💛 - Coveralls

@imobachgs imobachgs changed the base branch from master to after-release-beta2 March 12, 2025 11:41
* Save the logs into the installed system.
* Set the proper permissions (700) to the
  /var/log/agama-installation folder.
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the wrong target branch. Not it looks better :)

@imobachgs imobachgs merged commit 5adf2ac into after-release-beta2 Mar 12, 2025
15 checks passed
@imobachgs imobachgs deleted the collect-logs branch March 12, 2025 11:57
@imobachgs imobachgs mentioned this pull request Mar 27, 2025
imobachgs added a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants