Skip to content

Conversation

@imobachgs
Copy link
Contributor

Problem

Init scripts are executed properly. See #2144.

Solution

  • Run init scripts properly
  • Make agama-scripts.sh idempotent
  • Allow setting the scripts path with the SCRIPTS_DIR environment variable.
  • Do not exit with an error if there are not scripts

Testing

  • Tested manually

* Allow setting the scripts path with the SCRIPTS_DIR
  environment variable.
* Do not exit with an error if there are not scripts.
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just miss a changelog entry

@teclator
Copy link
Contributor

Even better now!, thanks (LGTM)!

@imobachgs imobachgs merged commit 52edc88 into master Mar 20, 2025
5 checks passed
@imobachgs imobachgs deleted the fix-init-scripts branch March 20, 2025 09:15
@imobachgs imobachgs mentioned this pull request Mar 27, 2025
imobachgs added a commit that referenced this pull request Mar 27, 2025
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 27, 2025
https://build.opensuse.org/request/show/1256465
by user IGonzalezSosa + anag+factory
- Version 13

- Support for manual files deployment in unattended mode
  (gh#agama-project/agama#2121)

- Do not try to connect to the HTTP server when it is not needed
  (gh#agama-project/agama#2192).

- Add extensions from the registration server (automatic
  installation only) (jsc#AGM-100)

- Improve init scripts execution (gh#agama-project/agama#2161):
  * Properly run the scripts (gh#agama-project/agama#2144).
  * Allow setting the scripts path with the SCRIPTS_DIR
    environment variable.
  * Do not exit with an error if there are not scripts.
  * Make agama-scripts.sh idempotent.

- Extend storage model schema with LVM (gh#agama-project/agama#2089).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants