fix(web): avoid license language switcher overflowing the viewport#2120
Merged
dgdavid merged 9 commits intoafter-release-beta2from Mar 6, 2025
Merged
fix(web): avoid license language switcher overflowing the viewport#2120dgdavid merged 9 commits intoafter-release-beta2from
dgdavid merged 9 commits intoafter-release-beta2from
Conversation
By relying on the ModalHeader#help prop to put it outside of the h1 heading.
Making the overlay menu to be aligned to the right of the button.
By using the right prop instead of a dead one.
Replaced Select with Dropdown as it looks semantically more appropriate, although both use the same underlying component.
Missing change of 75a504d
dgdavid
changed the title
kobliha
approved these changes
Mar 6, 2025
Contributor
kobliha
left a comment
kobliha
left a comment
There was a problem hiding this comment.
Thew change looks good to me from the UI/UX perspective, but I can't comment on the code change itself.
Thanks for fixing!
imobachgs
approved these changes
Mar 6, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
Mar 27, 2025
Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The language selector in the product license dialog overflows on certain viewport sizes, making it impossible to select some options. See #2105
Solution
Use the #isScrollable prop.
Additional Changes
<h1>heading, and preventing nested<h1>elements.Tests
Screenshots