Allow to delete mandatory filesystems#2160
Merged
dgdavid merged 9 commits intoagama-project:masterfrom Mar 20, 2025
Merged
Conversation
ancorgs
commented
Mar 15, 2025
dgdavid
approved these changes
Mar 15, 2025
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
Despite adding a few NP comments, I consider this ready to merge if you'd like to do so
| import { useConfigErrors } from "~/queries/issues"; | ||
|
|
||
| const Description = ({ errors }) => { | ||
| return ( |
Contributor
There was a problem hiding this comment.
NP: I'm not sure if it should be a list when it is just one issue. But please, do not invest time on it now. This is mostly a comment for taking notes for future rounds of small improvements.
dgdavid
requested changes
Mar 17, 2025
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
I think it worth addressing @joseivanlopez comments at least.
ancorgs
force-pushed
the
delete_root_again
branch
from
ac8804b to
2adb1d5
Compare
Contributor
Author
|
Updated to cover all important comments, I hope. |
dgdavid
approved these changes
Mar 20, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
Mar 27, 2025
Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 27, 2025
https://build.opensuse.org/request/show/1256469 by user IGonzalezSosa + anag+factory - Version 13 - Add basic support for creating LVM volume groups and logical volumes (gh#agama-project/agama#2216). - Change switches by checkboxes (gh#agama-project/agama#2168). - Restructure the encryption form (gh#agama-project/agama#2168). - Properly handle empty lists of unsupported AutoYaST elements (gh#agama-project/agama#2196). - Stop parsing errors from SCC at frontend side and simply render them as returned by the backend (gh#agama-project/agama#2193). - Stop displaying the hostname alert once the system is registered (gh#agama-project/agama#2183). - Allow temporary removal of the root file system (gh#agama-project/agama#2160).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-incarnation of #2129, that was automatically closed by Github.
Problem
Agama does not allow to delete the "/" partition nor the drive containing it.
But that was only implemented to hide some limitations of the current UI. In fact, deleting "/" or any other mandatory partition should be allowed. Of course, a proposal without mandatory mount paths is not valid and cannot be computed. But that doesn’t mean the user cannot delete them temporarily in order to create it elsewhere.
Solution
Screenshots
Now the trash-can icon is there for root as well...
But nothing dramatic happens if the user clicks on it.
Testing