Skip to content

Do only one automatic download retry#2139

Merged
lslezak merged 1 commit intoafter-release-beta2from
reduce_retries
Mar 10, 2025
Merged

Do only one automatic download retry#2139
lslezak merged 1 commit intoafter-release-beta2from
reduce_retries

Conversation

@lslezak
Copy link
Contributor

@lslezak lslezak commented Mar 10, 2025

Problem

Solution

  • Change the number
  • Additionally the logic has been changed so the retry count really means the retry count. Before it was actually the total amount of attempts, not just the retries.

Additionally changed the logic so the retry count really means
the retry count (it was actually the total amount of attempts).
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since changes are against "after-release-beta2" branch I guess the changelog entry for this is the same than linked PR in the description (and already merged against same branch).

Thus, let's go ahead with merge.

Thanks!

@lslezak
Copy link
Contributor Author

lslezak commented Mar 10, 2025

Yes, that's why I did not add a new changelog entry.

@lslezak lslezak merged commit f10e7ed into after-release-beta2 Mar 10, 2025
6 checks passed
@lslezak lslezak deleted the reduce_retries branch March 10, 2025 17:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13770103924

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.499%

Totals Coverage Status
Change from base Build 13768617116: 0.0%
Covered Lines: 20017
Relevant Lines: 27610

💛 - Coveralls

@imobachgs imobachgs mentioned this pull request Mar 27, 2025
imobachgs added a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants