Skip to content

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Mar 13, 2025

This pull request implements support for selecting individual packages during the installation.

{
  "software": {
    "patterns": ["gnome_desktop"],
    "packages": ["vim"],
  }
}

Links

To improve

When a package does not exist, the problem is logged but not reported. We could handle this problem in a separate PR (or even a separate PBI) because we might need a way to handle a) errors in the PackagesProposal.

@imobachgs
Copy link
Contributor Author

@lslezak I need your help here 😉 I wonder whether it is better:

  • Add the packages to the proposal (using the SetResolvables method). The solver does not run after that, but we can fix that. Deselecting packages is not supported this way, but I'd like to know whether we need/want that.
  • Follow a similar approach to what we do with patterns: have a SetUserPatterns method at D-Bus level. This one is more complex, but it won't be hard to implement it.

We can start with a) and move to b) later. However, I would like to have the point of view of a software management expert.

@imobachgs imobachgs force-pushed the select-packages-proposal branch from 6076b1b to cd96909 Compare March 13, 2025 19:51
@lslezak
Copy link
Contributor

lslezak commented Mar 14, 2025

I do not know the details but I'd probably use the same mechanism as for selecting the mandatory packages from the product configuration. To be consistent.

@imobachgs
Copy link
Contributor Author

I do not know the details but I'd probably use the same mechanism as for selecting the mandatory packages from the product configuration. To be consistent.

Good point. Then I will continue with the current implementation that tuses the proposal's SetResolvables.

Thanks!

@imobachgs imobachgs force-pushed the select-packages-proposal branch from c460bd7 to 0497643 Compare March 14, 2025 11:25
@imobachgs imobachgs marked this pull request as ready for review March 14, 2025 12:24
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit be6a7c2 into after-release-beta2 Mar 14, 2025
9 checks passed
@imobachgs imobachgs deleted the select-packages-proposal branch March 14, 2025 14:42
@coveralls
Copy link

coveralls commented Mar 14, 2025

Pull Request Test Coverage Report for Build 13856620473

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 16 (56.25%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on select-packages-proposal at 72.324%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-server/src/software/web.rs 0 2 0.0%
rust/agama-lib/src/software/client.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 13837957018: 72.3%
Covered Lines: 20020
Relevant Lines: 27681

💛 - Coveralls

@imobachgs imobachgs mentioned this pull request Mar 27, 2025
imobachgs added a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants