-
Notifications
You must be signed in to change notification settings - Fork 69
feat: allow selecting individual packages #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lslezak I need your help here 😉 I wonder whether it is better:
We can start with a) and move to b) later. However, I would like to have the point of view of a software management expert. |
6076b1b to
cd96909
Compare
|
I do not know the details but I'd probably use the same mechanism as for selecting the mandatory packages from the product configuration. To be consistent. |
Good point. Then I will continue with the current implementation that tuses the proposal's SetResolvables. Thanks! |
c460bd7 to
0497643
Compare
teclator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Test Coverage Report for Build 13856620473Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216
This pull request implements support for selecting individual packages during the installation.
{ "software": { "patterns": ["gnome_desktop"], "packages": ["vim"], } }Links
To improve
When a package does not exist, the problem is logged but not reported. We could handle this problem in a separate PR (or even a separate PBI) because we might need a way to handle a) errors in the
PackagesProposal.