Copy files needed for NVMe from instsys to the target #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
reviewed
Apr 10, 2025
ancorgs
reviewed
Apr 11, 2025
Contributor
There was a problem hiding this comment.
In general, this looks good. Just some trivial requests on my side:
- Squash all the current commits into one
- Add some pointer somewhere to bug#1238038, either in a comment next to the filenames or in the commit message. So we can track why we started to copy these files.
- Add changelog entry and version bump
Contributor
Author
Updated & rebased. However I'm not sure about raising the version ... you mean in rubygem*.spec 12.devel16 -> 12.devel17 ? |
Contributor
Never mind. It's not really needed. My fault. |
Contributor
Author
|
There was a bug in destination directory (was hardcoded) ... fixed & updated testsuite to cover that |
ancorgs
reviewed
Apr 14, 2025
| FileUtils.mkdir_p(target) | ||
| FileUtils.cp(glob_files, target) | ||
| glob_files.each do |file| | ||
| target = File.dirname(file).sub(root_dir, dest_dir) |
Contributor
There was a problem hiding this comment.
This relies in the fact that dest_dir includes a final slash. That is, is "/mnt/". It would not work if dest_dir is "/mnt" (without the trailing slash). But I guess we can live with that.
Merged
imobachgs
added a commit
that referenced
this pull request
Apr 22, 2025
Prepare to release Agama 14: * #1994 * #2041 * #2103 * #2178 * #2189 * #2200 * #2205 * #2209 * #2212 * #2213 * #2214 * #2215 * #2216 * #2217 * #2219 * #2220 * #2224 * #2225 * #2226 * #2227 * #2228 * #2230 * #2231 * #2232 * #2233 * #2235 * #2237 * #2239 * #2241 * #2242 * #2244 * #2245 * #2246 * #2247 * #2248 * #2249 * #2250 * #2251 * #2252 * #2253 * #2254 * #2255 * #2256 * #2257 * #2259 * #2260 * #2262 * #2265 * #2266 * #2268 * #2269 * #2271 * #2272 * #2273 * #2275 * #2276 * #2278 * #2281
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Apr 23, 2025
https://build.opensuse.org/request/show/1272126 by user IGonzalezSosa + anag_factory - Version 14 - Fixed detection of iBFT (bsc#1239046). - Removed offload_card from iSCSI (bsc#1231385). - bsc#1238038 - copy NVMe configuration files from inst-sys to target (gh#agama-project/agama#2257). - Allow to specify extra kernel parameters for bootloader (jsc#PED-10810) - Add auto-installation support for iSCSI (gh#agama-project/agama#2231). - Write the registration URL to the installed system (bsc#1239316). - Make the extension version attribute optional, search the version automatically if it is missing (related to jsc#AGM-100) - Allow to specify bootloader timeout in profile (jsc#PED-10810) - Copy the hostname to the installed system if it exists (gh#agama-project/agama#2226). - Properly map AutoYaST scripts "source" to "content" - Always display the patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NVMe devices not properly discovered after installation and reboot to the target
bsc#1238038
Solution
Copy needed pieces of the configuration to the target
Testing