chore: merge after-release-beta2 into master
#2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting the file system label for the new partitions. Note: the label field only appears if the file system is going to be created (i.e., an existing file system is not reused). * https://bugzilla.suse.com/show_bug.cgi?id=1237165 * https://jira.suse.com/browse/AGM-122 
Agama-weblate commit: 99a8c944ddfc13f76cb37d53b000bdbbb8f9b8b1
Added spacing adjustments to enhance readability and reduce clutter.
## Problem Folowup of https://github.com/yast/yast-storage-ng/pull/1396/files#diff-d0c8ea3d63135679325c6c61b13d11f85edc06bbb141d983037c55846699e125R143 The above proposal intoduced BLS boot proposal. Only limitation was target architecture, but it doesn't fit for conservative products like SLE for now. ## Solution Added product based condition for seting nev variable controling BLS selection in storage-ng. BLS is proposed only for tumbleweed (including Slowroll) ## Testing - *Added a new unit test* - *Tested manually*
- Decrease the libzypp timeout from the default 60 seconds to 20 seconds - Automatically retry package download or repository refresh before reporting an error - Display proper Agama version in the console
## Problem - Too long timeout for network operations - No automatic retry ## Solution - Decrease the libzypp timeout from the default 60 seconds to 20 seconds - Automatically retry package download or repository refresh before reporting an error ## Additional fix - Display proper Agama version in the console - The original problem:  ## Testing - Added new unit tests - Tested manually, the repository refresh or package download is tried 3 times before reporting and error
## Problem Currently the backend and the UI does not allow to set the system hostname, and the kernel cmdline argument only allow to set the transient hostname. - https://trello.com/c/V2GgJrWo/4349-5-agama-add-support-for-setting-the-hostname ## Solution - Added a hostname specific model and API for getting/setting the transient and persistent hostname. - Set the persistent hostname in dracut if the hostname option is given as linuxrc used to do. - Allow to disable the manage of the hostname only in case the kernel cmdline SetHostname option is given - By now we will not expose the hostname-mode or the via_dhcp option through the profile or config.. see below some notes and clarifications about it. > I decided to not expose the by_dhcp option by now until discussed, and maybe renaming it to `via_dhcp` would be better, or just use `mode` allowing to set it to {default|dhcp|none}. > > From the doc page ... https://networkmanager.pages.freedesktop.org/NetworkManager/NetworkManager/NetworkManager.conf.html > > hostname-mode > > Set the management mode of the hostname. This parameter will affect only the transient hostname. If a valid static hostname is set, NetworkManager will skip the update of the hostname despite the value of this option. An hostname empty or equal to 'localhost', 'localhost6', 'localhost.localdomain' or 'localhost6.localdomain' is considered invalid. > > default: NetworkManager will update the hostname with the one provided via DHCP or reverse DNS lookup of the IP address on the connection with the default route or on any connection with the property hostname.only-from-default set to 'false'. Connections are considered in order of increasing value of the hostname.priority property. In case multiple connections have the same priority, connections activated earlier are considered first. If no hostname can be determined in such way, the hostname will be updated to the last one set outside NetworkManager or to 'localhost.localdomain'. > > dhcp: this is similar to 'default', with the difference that after trying to get the DHCP hostname, reverse DNS lookup is not done. Note that selecting this option is equivalent to setting the property 'hostname.from-dns-lookup' to 'false' globally for all connections in NetworkManager.conf. > > none: NetworkManager will not manage the transient hostname and will never set it. > > So, basically, if a static hostname is set then it will not be updated by any DHCP Ack. Therefore, I'm even considering to not expose it. > > In linurxc we had the SetHostname option for disabling set the hostname via DHCP. Currently the kernel cmdline argument hostname=test only sets the transient hostname, but this PR add the linuxrc behavior setting the persistent hostname which prevents the hostname to be modified via DHCP, but it also allows to pass the SetHostname=0 to set the hostname-mode to none disabling the manage of the transient hostname by NetworkManager. This option is what we wanted to offer in the interface, but as setting the persistent hostname is enough I think we can omit it by now. > > With linuxrc was different, the persistent hostname can be modified via DHCP if not disable the DHCP hostname. ## Testing - *Tested manually*
This pull request implements support for selecting individual packages
during the installation.
```json
{
"software": {
"patterns": ["gnome_desktop"],
"packages": ["vim"],
}
}
```
## Links
* Trello: https://trello.com/c/Ondb9itc/
## To improve
When a package does not exist, the problem is logged but not reported.
We could handle this problem in a separate PR (or even a separate PBI)
because we might need a way to handle a) errors in the
`PackagesProposal`.
Bring master changes to `after-release-beta2` branch.
ancorgs
reviewed
Mar 14, 2025
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
Is it ok to merge all the .github/workflows stuff into master or are they somehow specific to this branch?
Contributor
Author
I would say it is a question for @lslezak. |
Contributor
|
Those a designed for |
Merged
imobachgs
added a commit
that referenced
this pull request
Mar 27, 2025
Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the
after-release-beta2branch tomaster.