Skip to content

feat(ui): show volume groups#2089

Merged
joseivanlopez merged 22 commits intoagama-project:storage-lvmfrom
joseivanlopez:storage-show-vgs
Mar 10, 2025
Merged

feat(ui): show volume groups#2089
joseivanlopez merged 22 commits intoagama-project:storage-lvmfrom
joseivanlopez:storage-show-vgs

Conversation

@joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Feb 27, 2025

Show the volume groups used for the installation and their logical volumes.

Note: The volume groups and logical volumes cannot be edited yet.

Screenshot From 2025-03-07 11-35-51

Screenshot From 2025-03-06 16-05-56

@joseivanlopez joseivanlopez changed the base branch from master to after-release-beta2 February 27, 2025 13:25
@coveralls
Copy link

coveralls commented Feb 27, 2025

Pull Request Test Coverage Report for Build 13763915231

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 116 of 118 (98.31%) changed or added relevant lines in 15 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 72.647%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/lib/agama/storage/config_conversions/to_model_conversions.rb 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
service/service/lib/agama/storage/proposal.rb 3 97.76%
service/service/lib/agama/storage/config_conversions/to_model_conversions.rb 4 0.0%
Totals Coverage Status
Change from base Build 13723327916: 0.2%
Covered Lines: 20190
Relevant Lines: 27792

💛 - Coveralls

@joseivanlopez joseivanlopez force-pushed the storage-show-vgs branch 12 times, most recently from 5498aeb to 986da5e Compare March 7, 2025 11:51
@joseivanlopez joseivanlopez marked this pull request as ready for review March 7, 2025 11:51
@joseivanlopez joseivanlopez changed the base branch from after-release-beta2 to storage-lvm March 7, 2025 15:01
@ancorgs
Copy link
Contributor

ancorgs commented Mar 7, 2025

Just for the record. We agreed to proceed with this model, but we will need to revisit it in the future since it has some consistency problems.

For example, drives have a property name that contains the device name of the real device referenced by the drive. On the other hand, volume groups also have a name property but it refers to the name of the volume group. That's not only confusing, but it will be conflictive in the future when we introduce the possibility to reuse an existing volume group.

@ancorgs

This comment was marked as resolved.

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review it in depth, especially the components since I expect more changes on them and I need more time to think on them. However, I think we can go ahead.

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead, thanks.

@joseivanlopez joseivanlopez merged commit 8fefec1 into agama-project:storage-lvm Mar 10, 2025
5 checks passed
@imobachgs imobachgs mentioned this pull request Mar 27, 2025
imobachgs added a commit that referenced this pull request Mar 27, 2025
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Mar 27, 2025
https://build.opensuse.org/request/show/1256465
by user IGonzalezSosa + anag+factory
- Version 13

- Support for manual files deployment in unattended mode
  (gh#agama-project/agama#2121)

- Do not try to connect to the HTTP server when it is not needed
  (gh#agama-project/agama#2192).

- Add extensions from the registration server (automatic
  installation only) (jsc#AGM-100)

- Improve init scripts execution (gh#agama-project/agama#2161):
  * Properly run the scripts (gh#agama-project/agama#2144).
  * Allow setting the scripts path with the SCRIPTS_DIR
    environment variable.
  * Do not exit with an error if there are not scripts.
  * Make agama-scripts.sh idempotent.

- Extend storage model schema with LVM (gh#agama-project/agama#2089).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants