Conversation
* Do not build the HTTP client for those commands that do not need one.
dgdavid
approved these changes
Mar 23, 2025
dgdavid
approved these changes
Mar 24, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
Mar 27, 2025
Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Mar 27, 2025
https://build.opensuse.org/request/show/1256465 by user IGonzalezSosa + anag+factory - Version 13 - Support for manual files deployment in unattended mode (gh#agama-project/agama#2121) - Do not try to connect to the HTTP server when it is not needed (gh#agama-project/agama#2192). - Add extensions from the registration server (automatic installation only) (jsc#AGM-100) - Improve init scripts execution (gh#agama-project/agama#2161): * Properly run the scripts (gh#agama-project/agama#2144). * Allow setting the scripts path with the SCRIPTS_DIR environment variable. * Do not exit with an error if there are not scripts. * Make agama-scripts.sh idempotent. - Extend storage model schema with LVM (gh#agama-project/agama#2089).
imobachgs
added a commit
that referenced
this pull request
Apr 2, 2025
## Problem YaST-like URLs are not supported for info files because we use CURL to retrieve the file. Fixes #2176. ## Solution Use "agama download" to get the info file. ## Testing - Updated the integration test. > [!WARNING] > The tests fail because the `agama download` command tries to connect to the Agama HTTP server even if unnecessary. See #2192 for a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agama CLI tries to connect to the HTTP server even when it is unnecessary. For instance, when running the
agama download, the client will try to connect to the HTTP server.Solution
With this change, the Agama CLI will connect to the server only when needed.
Testing
Future work
I decided to make a simple fix because we plan to redesign the commands.