feat(web): manage logical volumes#2200
Merged
joseivanlopez merged 15 commits intoagama-project:storage-lvmfrom Mar 27, 2025
Merged
feat(web): manage logical volumes#2200joseivanlopez merged 15 commits intoagama-project:storage-lvmfrom
joseivanlopez merged 15 commits intoagama-project:storage-lvmfrom
Conversation
dgdavid
reviewed
Mar 24, 2025
joseivanlopez
force-pushed
the
manage-lvs
branch
5 times, most recently
from
9a00b56 to
14c9742
Compare
- Adapt hooks and helpers to use data types.
- In order to keep this change minimal, the form is still using separate states instead of a single stage holding a data type.
- Add, edit and delete logical volumes.
joseivanlopez
force-pushed
the
manage-lvs
branch
from
14c9742 to
619651a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
joseivanlopez
force-pushed
the
manage-lvs
branch
from
2cf0fc4 to
8b26586
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
I'm still not finished, but I have implemented some changes at joseivanlopez#7 |
Changes on top of latest LVM features
ancorgs
approved these changes
Mar 27, 2025
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
I have been playing with this branch and I can confirm it works (although I have checked the code only very very briefly).
So taking into account the context, it LGTM.
Merged
imobachgs
added a commit
that referenced
this pull request
Mar 27, 2025
Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216
Merged
imobachgs
added a commit
that referenced
this pull request
Apr 22, 2025
Prepare to release Agama 14: * #1994 * #2041 * #2103 * #2178 * #2189 * #2200 * #2205 * #2209 * #2212 * #2213 * #2214 * #2215 * #2216 * #2217 * #2219 * #2220 * #2224 * #2225 * #2226 * #2227 * #2228 * #2230 * #2231 * #2232 * #2233 * #2235 * #2237 * #2239 * #2241 * #2242 * #2244 * #2245 * #2246 * #2247 * #2248 * #2249 * #2250 * #2251 * #2252 * #2253 * #2254 * #2255 * #2256 * #2257 * #2259 * #2260 * #2262 * #2265 * #2266 * #2268 * #2269 * #2271 * #2272 * #2273 * #2275 * #2276 * #2278 * #2281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow managing LVM logical volumes (add, edit and delete).
Notes:
Disclaimer:
The code in this PR was done in a hurry for including LVM managent in SLE16 Beta3. It does not satisfy our expected quality thresholds and will be refactored as soon as possible.