feat: add support for some YaST-like URLs by imobachgs · Pull Request #2118 · agama-project/agama

imobachgs · 2025-03-05T17:43:04Z

Problem

Agama Transfer's API does not understand YaST-specific URLs.

It is impossible to handle URLs like usb://OEMDRV/autoinst.xml, device:///autoinst.xml, etc.

Note

It might not cover 100% of the old API cases, but we are working towards that.

Solution

This PR aims to add partial support for these URLs. The following schemes are supported: device:, usb:, label:, HD:, DVD: and cd:. Support for well-known URLs (e.g., file:, http:, https:, ftp:, nfs:, etc.) is still implemented using CURL.

Warning

agama download now requires specifying a DESTINATION file (instead of writing to stdout). Agama uses stdout to tell where it is searching.

Testing

Added a new unit test
Tested manually

Temporarily disable signature checking for dir:// because with the new product composer it is not possible to sign the repositories yet. It will be fixed in the future and we should remove this code then. See #2092 for further information. ## Testing * Add a unit test. * Manually tested.

Resync patterns list for SLES / SLES_SAP 16

## Problem QA tests of `agama profile import` fail because we did not package the storage part of the schema - https://bugzilla.suse.com/show_bug.cgi?id=1238367#c13 ## Solution 1. Package that file. 2. and remove the dangling reference to `guided` ## Testing - *Added a new unit test* - *Tested manually* ## Screenshots *If the fix affects the UI attach some screenshots here.*

This reverts commit 72f92b3.

This reverts commit 9198d6a.

Once the problem with the produce composer is fixed (see #2092), it is time to enable the signature checking again for `dir://` repositories.

rust/agama-cli/src/lib.rs

rust/agama-lib/src/utils/transfer/file_finder.rs

jreidinger · 2025-03-06T11:01:41Z

rust/agama-lib/src/utils/transfer/file_finder.rs

+        let source = mount_point.join(&file_name);
+        let result = Self::copy_file(source, writer);
+
+        if !file_system.is_mounted() {


this basically means that even if previously file system was already mounted, it will be unmounted here, which can be surprising and buggy. What about using closure like guarantee for mount that will handle it like

let file_name = file_name.strip_prefix("/").unwrap_or(file_name); let source = mount_point.join(&file_name); let result = file_system.ensure_mounted(&mount_point, || Self::copy_file(source, writer))

No, it will not umount the file system. The is_mounted() retains the original value, so there is no danger.

rust/agama-lib/src/utils/transfer/file_finder.rs

rust/agama-lib/src/utils/transfer/file_systems.rs

jreidinger · 2025-03-06T11:09:37Z

rust/agama-lib/src/utils/transfer/file_systems.rs

+                "--path",
+            ])
+            .output()
+            .unwrap();


this deserve at least todo for failures to report it more nicely.

rust/agama-lib/src/utils/transfer/file_systems.rs

rust/agama-lib/src/utils/transfer/handlers/yast.rs

coveralls · 2025-03-06T16:36:29Z

Pull Request Test Coverage Report for Build 13699080004

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

37 of 156 (23.72%) changed or added relevant lines in 8 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 72.479%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rust/agama-lib/src/scripts/model.rs	0	1	0.0%
rust/agama-cli/src/profile.rs	0	2	0.0%
rust/agama-lib/src/utils/transfer.rs	0	7	0.0%
rust/agama-cli/src/lib.rs	0	8	0.0%
rust/agama-lib/src/utils/transfer/handlers/generic.rs	0	9	0.0%
rust/agama-lib/src/utils/transfer/file_finder.rs	0	15	0.0%
rust/agama-lib/src/utils/transfer/file_systems.rs	37	73	50.68%
rust/agama-lib/src/utils/transfer/handlers/yast.rs	0	41	0.0%

Files with Coverage Reduction	New Missed Lines	%
rust/agama-cli/src/lib.rs	1	0.0%
rust/agama-server/tests/common/mod.rs	5	74.19%

Totals
Change from base Build 13680801738:	-0.3%
Covered Lines:	20010
Relevant Lines:	27608

💛 - Coveralls

Prepare for releasing Agama 13: - #2041 - #2074 - #2088 - #2089 - #2094 - #2097 - #2098 - #2100 - #2101 - #2104 - #2106 - #2107 - #2108 - #2113 - #2115 - #2116 - #2117 - #2118 - #2120 - #2121 - #2122 - #2123 - #2124 - #2125 - #2126 - #2128 - #2132 - #2135 - #2136 - #2137 - #2139 - #2142 - #2145 - #2146 - #2147 - #2148 - #2151 - #2153 - #2155 - #2156 - #2157 - #2158 - #2159 - #2160 - #2161 - #2163 - #2165 - #2172 - #2174 - #2177 - #2179 - #2180 - #2181 - #2182 - #2183 - #2184 - #2186 - #2187 - #2188 - #2191 - #2192 - #2193 - #2195 - #2197 - #2198 - #2199 - #2200 - #2201 - #2203 - #2204 - #2205 - #2206 - #2207 - #2209 - #2212 - #2213 - #2214 - #2215 - #2216

imobachgs and others added 26 commits February 28, 2025 13:06

feat(ruby): disable signature checking for dir:// repositories

9198d6a

docs(ruby): update changes file

042d6f0

fix(service): fix local directory URL

72f92b3

Adapt SLES / SLES_SAP 16 to new patterns

35370c1

add changelog entry for patterns update

ad2b830

Update patterns for SLES / SLES_SAP 16 (#2104)

4088304

Resync patterns list for SLES / SLES_SAP 16

storage: remove leftover in storage schema

fff357d

remove /storage/guided also from profile example

5d9a295

install and package also storage.schema.json (bsc#1238367)

7656a16

Revert "fix(service): fix local directory URL"

8b4e2ee

This reverts commit 72f92b3.

Revert "feat(ruby): disable signature checking for dir:// repositories"

a0d4bb4

This reverts commit 9198d6a.

docs(ruby): update changes file

8450886

feat(ruby): enable signature checking for dir:// repositories (#2113)

ae7bbcc

Once the problem with the produce composer is fixed (see #2092), it is time to enable the signature checking again for `dir://` repositories.

refactor(rust): extract Transfer::get to a generic handler

de64b3a

feat(rust): add support for device:, usb:, label: and hd/dvd/cd: URLs

9ffba96

fix(rust): adapt to Transfer::get API changes

142901f

docs(rust): extend transfer API documentation

68fb418

feat(rust): extract label: to a separate LabelHandler

61e9154

refactor(rust): move transfer handlers to separate modules

a876d6c

feat(rust)!: the download command expects a destination

54ed4b4

feat(rust): add some feedback to "agama download"

bfddec2

refactor(rust): use lsblk --pairs to read the file systems

353de60

fix(rust): FileSystemReader uses the shortest path as mount point

f6a6f9e

fix(rust): FileSystem includes the whole block device

d8f4a6e

imobachgs marked this pull request as ready for review March 6, 2025 10:17