fix(web): make hostname strings fully translatable #2268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@ancorgs detected and reported some not translatable strings at HostnamePage.tsx
Solution
Make them translatable and take the opportunity for avoid the usage of "please" word according to SUSE documentation style guide, https://documentation.suse.com/style/current/single-html/docu_styleguide/index.html#sec-vocabulary
Notes
A new
setRequestErrorhas been added for simplicity, since it make no sense to render something likeEven when such an error will likely not happen. So, better to go for
The presence or not presence of the dot at the end of the sentence it is also intentional: it's not used in titles
Of course, it is needed a better error reporting for forms to easily distinguish between validation warnings and request errors, but sadly Agama is not there at the time of sending this hotfix to make possible the translation of these texts. Thus, skipping further improvements in this form until such a goal can be achieved.