Skip to content

Fixed killing the checkmedia service too early #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lslezak merged 2 commits into from
Mar 17, 2025
Merged

Fixed killing the checkmedia service too early #2165

lslezak merged 2 commits into from
Mar 17, 2025

Conversation

@lslezak
Copy link
Contributor

@lslezak lslezak commented Mar 17, 2025

Problem

  • The checkmedia service is terminated by systemd quickly after start, the check did not run fully

checkmedia-failed

Solution

  • After some experimenting with the systemd services I came to this solution. Do not ask me for details. 😄

Testing

  • Tested with manually modified service file before booting
  • Tested also with a locally built Live ISO

checkmedia-fixed

dgdavid
dgdavid approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do not have too much knowledge here, but I fully trust in your experiments and tests. So, go ahead with merge if you want.

Thanks!

@lslezak lslezak merged commit 50061ca into master Mar 17, 2025
7 checks passed
@lslezak lslezak deleted the checkmedia_fix branch March 17, 2025 12:51
@imobachgs imobachgs mentioned this pull request Mar 27, 2025
Merged
imobachgs added a commit that referenced this pull request Mar 27, 2025
@imobachgs
Update to release 13 (#2217)
e176c9d 
Prepare for releasing Agama 13:

- #2041
- #2074
- #2088
- #2089
- #2094
- #2097
- #2098
- #2100
- #2101
- #2104
- #2106
- #2107
- #2108
- #2113
- #2115
- #2116
- #2117
- #2118
- #2120
- #2121
- #2122
- #2123
- #2124
- #2125
- #2126
- #2128
- #2132
- #2135
- #2136
- #2137
- #2139
- #2142
- #2145
- #2146
- #2147
- #2148
- #2151
- #2153
- #2155
- #2156
- #2157
- #2158
- #2159
- #2160
- #2161
- #2163
- #2165
- #2172
- #2174
- #2177
- #2179
- #2180
- #2181
- #2182
- #2183
- #2184
- #2186
- #2187
- #2188
- #2191
- #2192
- #2193
- #2195
- #2197
- #2198
- #2199
- #2200
- #2201
- #2203
- #2204
- #2205
- #2206
- #2207
- #2209
- #2212
- #2213
- #2214
- #2215
- #2216
@lslezak lslezak mentioned this pull request Apr 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lslezak @dgdavid