feat(rust): replace --api option by --host #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
replace-api-option
branch
from
f230934 to
b3083fb
Compare
imobachgs
approved these changes
Apr 16, 2025
Contributor
|
This will break my use case of connecting to the same host but different port (forwarded to a container) |
mvidner
requested changes
Apr 16, 2025
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
This will break my use case of connecting to the same host but different port (forwarded to a container)
OK, false alarm, it will continue to work, but the description did not make it clear.
But let me put the examples where the user will see them.
Also omit the default value fro mthe description, clap provides it
automatically:
```console
[...]
Options:
--host <HOST> URI pointing to Agama's remote host [default: http://localhost]
[...]
[...]
Options:
--host <HOST>
URI pointing to Agama's remote host.
Examples: https://my-server.lan my-server.local localhost:10443
[default: http://localhost]
[...]
```
mvidner
approved these changes
Apr 16, 2025
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
With my improvement, I like it too now :)
Merged
imobachgs
added a commit
that referenced
this pull request
Apr 22, 2025
Prepare to release Agama 14: * #1994 * #2041 * #2103 * #2178 * #2189 * #2200 * #2205 * #2209 * #2212 * #2213 * #2214 * #2215 * #2216 * #2217 * #2219 * #2220 * #2224 * #2225 * #2226 * #2227 * #2228 * #2230 * #2231 * #2232 * #2233 * #2235 * #2237 * #2239 * #2241 * #2242 * #2244 * #2245 * #2246 * #2247 * #2248 * #2249 * #2250 * #2251 * #2252 * #2253 * #2254 * #2255 * #2256 * #2257 * #2259 * #2260 * #2262 * #2265 * #2266 * #2268 * #2269 * #2271 * #2272 * #2273 * #2275 * #2276 * #2278 * #2281
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Apr 23, 2025
https://build.opensuse.org/request/show/1272124 by user IGonzalezSosa + anag_factory - Version 14 - CLI: wait a bit between selecting the product to install and registering it so the Web UI has enough time to process all events (gh#agama-project/agama#2274) - Allow to log in into multiple systems (gh#agama-project/agama#2261). - Do not interactively ask for accepting insecure connections. - Report and emit changes to the connections states. (gh#agama-project/agama#2247). - Do not write wireless security settings when they are not used. - Add missing help to finish command (gh#agama-project/agama#2272). - Replace --api option by --host (gh#agama-project/agama#2271). - Prevent agama-web-server from getting stuck in the POST /api/profile/autoyast calls (gh#agama-project/agama#2259). - Temporarily disable AutoYaST profiles fetch errors. - Allow to specify extra ker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI allows connecting to a different server by using the
--api <URL>option, but that URL differs from the URL you use in the browser (https://localhost vs https://localhost/api). Ideally, the same URL should be used for both CLI and browser clients.#2263
Solution
The
--apioption is replaced by--host, which allows indicating a host name or IP address without the /api suffix. The protocol is optional, using https if omitted. The default host is http://localhost.Examples: