Skip to content

Conversation

@lslezak
Copy link
Contributor

@lslezak lslezak commented Mar 27, 2025

Problem

  • The extensions might define additional patterns, but currently only the explicitly listed patterns are displayed in the software selection.
  • The problem is that we do not know the extension patterns in advance and in the future we will support custom repositories which might contain 3rd party patterns.

Solution

  • Do the pattern filtering only for the patterns from the base product repository (there are lots of patterns), always display the patterns from other repositories (usually there are just few of them).

GitHub Action

  • Allow the Coveralls step fail in the service CI.
  • For some reason it is currently failing, do not fail whole check if just coverage cannot be sent.

Testing

  • Updated unit test
  • Tested manually

Screenshots

The HA-SLES pattern from the HA extension is still displayed in the software selection even after removing it from the display list.

agama-ha-pattern2

Copy link
Contributor

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please name the cryptic true

@lslezak lslezak merged commit 3415a88 into master Mar 28, 2025
11 checks passed
@lslezak lslezak deleted the show_all_addon_patterns branch March 28, 2025 08:30
@imobachgs imobachgs mentioned this pull request Apr 22, 2025
imobachgs added a commit that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants