Skip to content

fix(rust): add extension to the "filename" in the disposition header#2151

Merged
imobachgs merged 2 commits intoafter-release-beta2from
fix-logs-filename
Mar 12, 2025
Merged

fix(rust): add extension to the "filename" in the disposition header#2151
imobachgs merged 2 commits intoafter-release-beta2from
fix-logs-filename

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

Problem

When downloading the logs, Chrom(ium|e) does not add an extension to the file name. In Firefox it seems to work just fine. See #2141.

Solution

Set the extension in the filename so Chromium uses the correct name.

Testing

  • Tested manually

Screenshots

If the fix affects the UI attach some screenshots here.

@imobachgs imobachgs added the good first issue Good for newcomers label Mar 12, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13812207531

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-16.7%) to 72.477%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-server/src/manager/web.rs 0 6 0.0%
Totals Coverage Status
Change from base Build 13810759906: -16.7%
Covered Lines: 20016
Relevant Lines: 27617

💛 - Coveralls

@imobachgs imobachgs linked an issue Mar 12, 2025 that may be closed by this pull request
@imobachgs imobachgs merged commit 942c253 into after-release-beta2 Mar 12, 2025
3 checks passed
@imobachgs imobachgs deleted the fix-logs-filename branch March 12, 2025 13:31
@imobachgs imobachgs mentioned this pull request Mar 27, 2025
imobachgs added a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downloading logs via remote browser gets agama-logs with no suffix

3 participants