Skip to content

Set BLS env for storage-ng according to the product selection#2097

Merged
mchf merged 7 commits intoafter-release-beta2from
env-storage
Mar 5, 2025
Merged

Set BLS env for storage-ng according to the product selection#2097
mchf merged 7 commits intoafter-release-beta2from
env-storage

Conversation

@mchf
Copy link
Contributor

@mchf mchf commented Feb 28, 2025

Problem

Folowup of https://github.com/yast/yast-storage-ng/pull/1396/files#diff-d0c8ea3d63135679325c6c61b13d11f85edc06bbb141d983037c55846699e125R143

The above proposal intoduced BLS boot proposal. Only limitation was target architecture, but it doesn't fit for conservative products like SLE for now.

Solution

Added product based condition for seting nev variable controling BLS selection in storage-ng. BLS is proposed only for tumbleweed (including Slowroll)

Testing

  • Added a new unit test
  • Tested manually

@mchf mchf marked this pull request as ready for review February 28, 2025 18:34
@mchf mchf requested a review from ancorgs February 28, 2025 18:34
@coveralls
Copy link

coveralls commented Feb 28, 2025

Pull Request Test Coverage Report for Build 13633919212

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on env-storage at 72.685%

Totals Coverage Status
Change from base Build 13591764851: 72.7%
Covered Lines: 19918
Relevant Lines: 27403

💛 - Coveralls

@mchf mchf requested a review from ancorgs March 4, 2025 16:56
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Especially if it's already tested manually. Please:

  • Add a changelog
  • Re-target it to the branch "after-release-beta2"

@mchf mchf changed the base branch from master to after-release-beta2 March 5, 2025 08:05
@mchf
Copy link
Contributor Author

mchf commented Mar 5, 2025

This looks good. Especially if it's already tested manually.

Just for record. The manual test was:
i had no system suitable for UEFI boot, so I:

  • ran patched agama installer, picked Slowroll (or non Tumbleweed product later on)
  • custom patched yast-storage-ng, added log message to see whether it sees updated YAST_NO_BLS_BOOT env variable - nothing for Slowroll or "1" for non Tumbleweed products - in boot strategy proposal method

@mchf mchf requested a review from ancorgs March 5, 2025 08:22
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchf mchf merged commit eb2361a into after-release-beta2 Mar 5, 2025
8 checks passed
@mchf mchf deleted the env-storage branch March 5, 2025 14:01
@imobachgs imobachgs mentioned this pull request Mar 27, 2025
imobachgs added a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants