Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.12.0 proposal #21593

Merged
merged 279 commits into from
Sep 11, 2018
Merged

v8.12.0 proposal #21593

merged 279 commits into from
Sep 11, 2018

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Jun 29, 2018 •
edited
Loading

trying a bit of a different approach here.

This is a release based on all the commits that are currently on v8.x-staging

There is a backlog of around 1200 commits that have not been audited for this release

https://gist.github.com/MylesBorins/078554dfc521fe945a6f45324206ec0e

This is a semver-minor release... as such we are going to want to bake longer with an r.c. process.

If you know of specific 8.x bugs that we should fix, any commits / prs from the above list, or features you want to be considered for this minor please comment on this issue and the @nodejs/lts and @nodejs/backporters team will review and land as appropriate.

If individuals don't see anything pressing for 8.x we'll ship it with what is in this PR. Assume that all currently open backport PRs are going to be triages, if they land this PR will be updated accordingly.

2018-09-11, Version 8.12.0 'Carbon' (LTS), @MylesBorins

Notable Changes

@nodejs-github-bot
Copy link
Collaborator

@MylesBorins build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/176/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory. v8.x labels Jun 29, 2018
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/collaborators please chime in

@MylesBorins MylesBorins mentioned this pull request Jun 29, 2018
Closed
@KoenLav KoenLav mentioned this pull request Jun 30, 2018
Merged
2 tasks
@mhdawson
Copy link
Member

mhdawson commented Jul 4, 2018

This would be my list of requested backports

[53f8563] - n-api: back up env before async work finalize (Gabriel Schulhof) #21129
[ba30d14] - n-api: throw when entry point is null (Gabriel Schulhof) #20779
[e61337d] - async_wrap: fix memory leak in AsyncResource (Michael Dawson) #20668
[b2d6eb7] - doc: cleanup n-api.md doc (Michael Dawson) #20430

@LaurentGoderre LaurentGoderre mentioned this pull request Jul 6, 2018
Closed
@lpinca
Copy link
Member

lpinca commented Jul 8, 2018

#20786 should be added if possible.

@gabrielschulhof
Copy link
Contributor

#21688 will land on Monday and should also go in, IMO.

@MylesBorins
Copy link
Contributor Author

@mhdawson b2d6eb7 and e61337d landed cleanly. The other two require manual backports and I've flagged them in the PRs

@lpinca #20786 needs to be manually backported

@gabrielschulhof #21688 does not land cleanly. Most likely we should batch a bunch of n-api patches... would you be able to look into this?

@MylesBorins
Copy link
Contributor Author

if rebased against staging and added as many of the requested commits as possible from above.

@mhdawson
Copy link
Member

mhdawson commented Jul 9, 2018

@gabrielschulhof would be great if you could land the n-api ones that did not land cleanly, looks likey you were the author of the original PRs so may be easiest for you to do the merge.

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jul 9, 2018 via email

@MylesBorins
Copy link
Contributor Author

to be explicit... please open a PR against v8.x-staging, atm our rules only allow LTS / Backporting team members to land on the staging branches

@robinst robinst mentioned this pull request Jul 16, 2018
Closed
@mhdawson mhdawson mentioned this pull request Jul 16, 2018
Closed
@veered
Copy link

veered commented Jul 18, 2018

Is there a way of using this experimental build inside of docker?

@benjamn
Copy link
Contributor

benjamn commented Jul 20, 2018

@veered Just did a build for Meteor, in case that helps:

@benjamn benjamn mentioned this pull request Jul 20, 2018
Closed
@benjamn
Copy link
Contributor

benjamn commented Jul 23, 2018

For what it's worth, all of Meteor's tests are passing with a prerelease build of 8.12.0 (meteor@d61084f, https://github.com/meteor/node/commits/v8.12.0-meteor). We will keep updating the build and running the tests as new commits are added to this PR.

mcollina
mcollina approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veered
Copy link

veered commented Jul 23, 2018

Yay!

@jordanrogers
Copy link

I'm not sure if folks are tracking it, but can we please make sure that #20786 is included? @lpinca backported as requested, and it has landed on v8.x-staging, but is not included in this PR yet. Thanks.

@watson watson mentioned this pull request Aug 1, 2018
Merged
3 tasks
ken23421 and others added 10 commits September 6, 2018 09:40
@ken23421 @MylesBorins
test: refactor http-https-default-ports
e1e6a09 
Use arrow functions.

Backport-PR-URL: #22380
PR-URL: #19130
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott @MylesBorins
test: address unreliable test-performance
8adb0b3 
test-performance can fail due to resource constraints. Move it from
parallel to sequential so it does not compete with other tests for
resources.

Fixes: #19197

Backport-PR-URL: #22380
PR-URL: #19228
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott @MylesBorins
test: do not check text for engine-generated error
e6131c2 
In test-tls-wrap-event-emitter, the text of a TypeError is checked as
part of the test. However, this text is generated by the JavaScript
engine (V8) and not Node.js. Thus, we should not check the text as JS
engine error messages can change without it being considered a breaking
change for Node.js.

A side effect is that node-chakracore will no longer need to patch this
test to pass.

Backport-PR-URL: #22380
PR-URL: #19215
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR @MylesBorins
doc: add warning to assert.doesNotThrow()
cae60ca 
Using `assert.doesNotThrow()` has no benefit over adding a comment
next to some code that should not throw. Therefore it is from now
on discouraged to use it.

Backport-PR-URL: #22380
PR-URL: #18699
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@princejwesley @MylesBorins
repl: better handling of recoverable errors
a6fca75 
Below syntax errors are handled without force .break/clear
  - Unexpected Token (prefix errors)
  - missing ) after argument list

In the multiline expression, recoverable errors are truly
recoverable, otherwise syntax error will be thrown.

Backport-PR-URL: #22380
PR-URL: #18915
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@pgrzesik @MylesBorins
test: Remove unnecessary asserion messages in test-crypto-hash.js
a0fd0b6 
This commit improves asserion messages in parallel/test-crypto-hash.js.
Instead of just simple string literal, messages are changed to also
include values used in assertion, which should improve debugging
in case of errors.

Backport-PR-URL: #22380
PR-URL: #18984
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@yhwang @MylesBorins
test: fix test-abort-backtrace in shared lib build
9c781f0 
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.

Refs: #18535

Signed-off-by: Yihong Wang <[email protected]>

Backport-PR-URL: #22380
PR-URL: #19213
Refs: #18535
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@vsemozhetbyt @MylesBorins
doc: fix/add link to Android info
a023193 
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

Backport-PR-URL: #22386
PR-URL: #19004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@vsemozhetbyt @MylesBorins
doc,tools: formalize, unify, codify default values
50316e2 
Backport-PR-URL: #22388
PR-URL: #19737
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax @MylesBorins
src: add environment cleanup hooks
66343c5 
This adds pairs of methods to the `Environment` class and to public APIs
which can add and remove cleanup handlers.

Unlike `AtExit`, this API targets addon developers rather than
embedders, giving them (and Node\u2019s internals) the ability to register
per-`Environment` cleanup work.

We may want to replace `AtExit` with this API at some point.

Many thanks for Stephen Belanger for reviewing the original version of
this commit in the Ayo.js project.

Refs: ayojs/ayo#82
Backport-PR-URL: #22435
PR-URL: #19377
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Sep 6, 2018
@MylesBorins
2018-09-11, Version 8.12.0 'Carbon' (LTS)
0c73307 
Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    #21592
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Sep 6, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17063/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1668/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1539/
rc.6: https://nodejs.org/download/rc/v8.12.0-rc.6/

@MylesBorins
2018-09-11, Version 8.12.0 'Carbon' (LTS)
731eed2 
Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    #21592
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
@MylesBorins
Copy link
Contributor Author

One more CITGM before pushing this out tomorrow

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1540/

@MylesBorins MylesBorins merged commit 731eed2 into v8.x Sep 11, 2018
MylesBorins added a commit that referenced this pull request Sep 11, 2018
@MylesBorins
Working on v8.12.1
1519657 
PR-URL: #21593
MylesBorins added a commit that referenced this pull request Sep 11, 2018
@MylesBorins
2018-09-11, Version 8.12.0 'Carbon' (LTS)
121439a 
Notable Changes:

* async_hooks:
  - rename PromiseWrap.parentId (Ali Ijaz Sheikh)
    #18633
  - remove runtime deprecation (Ali Ijaz Sheikh)
    #19517
  - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh)
    #18513
* cluster:
  - add cwd to cluster.settings (cjihrig)
    #18399
  - support windowsHide option for workers (Todd Wong)
    #17412
* crypto:
  - allow passing null as IV unless required (Tobias Nießen)
    #18644
* deps:
  - upgrade npm to 6.2.0 (Kat Marchán)
    #21592
  - upgrade libuv to 1.19.2 (cjihrig)
    #18918
  - Upgrade node-inspect to 1.11.5 (Jan Krems)
    #21055
* fs,net:
  - support as and as+ flags in stringToFlags() (Sarat Addepalli)
    #18801
  - emit 'ready' for fs streams and sockets (Sameer Srivastava)
    #19408
* http, http2:
  - add options to http.createServer() (Peter Marton)
    #15752
  - add 103 Early Hints status code (Yosuke Furukawa)
    #16644
  - add http fallback options to .createServer (Peter Marton)
    #15752
* n-api:
  - take n-api out of experimental (Michael Dawson)
    #19262
* perf_hooks:
  - add warning when too many entries in the timeline (James M Snell)
    #18087
* src:
  - add public API for managing NodePlatform (Cheng Zhao)
    #16981
  - allow --perf-(basic-)?prof in NODE\_OPTIONS (Leko)
    #17600
  - node internals' postmortem metadata (Matheus Marchini)
    #14901
* tls:
  - expose Finished messages in TLSSocket (Anton Salikhmetov)
    #19102
* **trace_events**:
  - add file pattern cli option (Andreas Madsen)
    #18480
* util:
  - implement util.getSystemErrorName() (Joyee Cheung)
    #18186

PR-URL: #21593
@MylesBorins MylesBorins mentioned this pull request Sep 11, 2018
Merged
MylesBorins added a commit to nodejs/nodejs.org that referenced this pull request Sep 11, 2018
@MylesBorins
blog: add release post for v8.12.0
37e1c7d 
Refs: nodejs/node#21593
jhford added a commit to taskcluster/ec2-manager that referenced this pull request Sep 13, 2018
@jhford
Deployment changes
ee3301c 
There's a couple changes we need because of our Heroku environment.  One
of them is to go back to using Node 8.11.4.  While we wish to use Node
10 here, in advance of iid-verify, there's a bug somewhere which breaks
the Postgres library.

The main reason for Node 10 was for a stable N-Api, but it turns out
that Node 8.12 will bump N-Api to stable status per:

nodejs/node#21593
jhford added a commit to taskcluster/ec2-manager that referenced this pull request Sep 13, 2018
@jhford
Move node version and change some deployment settings
1e0e338 
There's a couple changes we need because of our Heroku environment.  One
of them is to go back to using Node 8.11.4.  While we wish to use Node
10 here, in advance of iid-verify, there's a bug somewhere which breaks
the Postgres library.

The main reason for Node 10 was for a stable N-Api, but it turns out
that Node 8.12 will bump N-Api to stable status per:

nodejs/node#21593
jhford added a commit to taskcluster/ec2-manager that referenced this pull request Sep 14, 2018
@jhford
dependency and CI fixes (#71)
0296af4 
* Move node version and change some deployment settings

There's a couple changes we need because of our Heroku environment.  One
of them is to go back to using Node 8.11.4.  While we wish to use Node
10 here, in advance of iid-verify, there's a bug somewhere which breaks
the Postgres library.

The main reason for Node 10 was for a stable N-Api, but it turns out
that Node 8.12 will bump N-Api to stable status per:

nodejs/node#21593

* Add app.json to enable heroku ci tests

* Remove travis support

* Remove travis build status from readme
@targos targos deleted the v8.12.0-proposal branch October 27, 2018 08:58
@brokencube brokencube mentioned this pull request Nov 9, 2018
Closed
@Flarna Flarna mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.