-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: doc cleanup #20430
doc: doc cleanup #20430
Conversation
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
(nit: on landing, the commit message title needs to be changed into |
@gabrielf can you review this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nit: s/Partical/Partial/ in the commit message. |
Partial doc cleanup as per nodejs#20421
Fixed up commit comment, previous CI run looked good, will land. |
Landed as 4740e5d |
Partial doc cleanup as per #20421 PR-URL: #20430 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Partial doc cleanup as per #20421 PR-URL: #20430 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Partial doc cleanup as per #20421 PR-URL: #20430 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Partial doc cleanup as per #20421 PR-URL: #20430 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Partial doc cleanup as per #20421 PR-URL: #20430 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Partial doc cleanup as per #20421 PR-URL: #20430 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Partial doc cleanup as per
#20421
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes