Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove extra space in README.md #18822

Closed
wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

Extra spaces in the Collaborators List will break node-core-utils's get-metadata.

Checklist
Affected core subsystem(s)

doc

@mmarchini mmarchini added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 16, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 16, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
@BridgeAR
Copy link
Member

Running a CI should not be necessary here.

@mmarchini
Copy link
Contributor Author

Landed in f25104e

mmarchini pushed a commit that referenced this pull request Feb 16, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <[email protected]>
@ChALkeR
Copy link
Member

ChALkeR commented Feb 16, 2018

Closing as it's landed.

@ChALkeR ChALkeR closed this Feb 16, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants