[8.x] deps: V8: cherry-pick 8361fa58 from upstream #21294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofrobots sadly an error occured when I tried to trigger a build :( |
nodejs-github-bot
added
v8 engine
2 tasks
MylesBorins
force-pushed
the
v8.x-staging
branch
from
084ef60
to
859dc64
Compare
|
this is going to need a rebase and another CI kick off |
ofrobots
force-pushed
the
backport/8/806388
branch
from
fa01875
to
2a47c7d
Compare
|
@mhdawson the V8-CI seems to be failing on ppcle and s390x. Any ideas why? |
|
@nodejs/build @mhdawson ping on the V8-CI issues above. |
|
I fixed the s390 issue a few days ago as mentioned on the other PR. |
ofrobots
added
blocked
|
Fresh V8 CI now that the CI issues are fixed: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1495/ |
|
@nodejs/lts @nodejs/v8-update this needs an LGTM before this back-port can land. |
Original commit message: [runtime] Fix derived class instantiation Bug: chromium:806388 Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c Reviewed-on: https://chromium-review.googlesource.com/894942 Reviewed-by: Igor Sheludko <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#50990} PR-URL: nodejs#21294 Reviewed-By: Myles Borins <[email protected]>
ofrobots
force-pushed
the
backport/8/806388
branch
from
2a47c7d
to
a075cbe
Compare
|
Thanks!. Landed on |
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Original commit message: [runtime] Fix derived class instantiation Bug: chromium:806388 Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c Reviewed-on: https://chromium-review.googlesource.com/894942 Reviewed-by: Igor Sheludko <[email protected]> Commit-Queue: Camillo Bruni <[email protected]> Cr-Commit-Position: refs/heads/master@{#50990} PR-URL: #21294 Reviewed-By: Myles Borins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9.x: #21293
Original commit message:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/v8-update